Skip to content

Update Docusaurus #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moyeah wants to merge 11 commits into from
Closed

Update Docusaurus #3406

moyeah wants to merge 11 commits into from

Conversation

@moyeah
Copy link
Contributor

@moyeah moyeah commented Sep 18, 2023 •
edited
Loading

Description

Update Docusaurus

Included suggested comments from @hamza1311 on #3403.

@moyeah
Remove whitespace in website tutorial
19dd55e
@moyeah
Update index.mdx
ea3c196 
Remove whitespace in tutorial.
@moyeah
Add more information to website.
dc2c914 
Changes to be committed:
	modified:   website/docs/tutorial/index.mdx
	modified:   website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx
	modified:   website/versioned_docs/version-0.20/tutorial/index.mdx
@moyeah
Remove error: doctest failed, to rerun pass -p website-test --doc
c0dcfb8 
Changes to be committed:
	modified:   website/docs/migration-guides/yew/from-0_18_0-to-0_19_0.mdx
@moyeah
Correction of minor mistakes in website.
a109676 
Changes to be committed:
	modified:   website/docs/getting-started/build-a-sample-app.mdx
	modified:   website/docs/tutorial/index.mdx
	modified:   website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx
	modified:   website/versioned_docs/version-0.20/tutorial/index.mdx
@moyeah
Run Prettier
5628bfe 
Changes to be committed:
	new file:   package-lock.json
	modified:   website/docs/tutorial/index.mdx
	modified:   website/package-lock.json
	modified:   website/package.json
	modified:   website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx
@moyeah
Changes to be committed:
2e2a442 
	modified:   package-lock.json
	modified:   package.json
@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 86ec288):

https://yew-rs--pr3406-update-docusaurus-uckaksot.web.app

(expires Fri, 06 Oct 2023 15:22:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

cecton
cecton previously approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@cecton cecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh this PR is mixed with #3405 maybe on purpose? It probably doesn't matter at all

ranile
ranile requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase/merge to include the commits from master?

@moyeah
Included suggested changes by hamza1311 from PR#3403 - Add info to we…
400c352 
…bsite

Changes to be committed:
	modified:   website/docs/tutorial/index.mdx
	modified:   website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx
@moyeah moyeah mentioned this pull request Sep 23, 2023
Closed
@moyeah moyeah requested a review from ranile September 23, 2023 18:40
@ranile
Copy link
Member

ranile commented Sep 29, 2023

@moyeah I'm so sorry for repeatedly asking for changes but can you please ensure there are no conflicts and this PR only updates Docusaurus

@moyeah
Copy link
Contributor Author

moyeah commented Sep 29, 2023

@moyeah I'm so sorry for repeatedly asking for changes but can you please ensure there are no conflicts and this PR only updates Docusaurus

@hamza1311 no need for sorry. I will do it as soon I get a time slot to do it.

@ranile
Copy link
Member

ranile commented Sep 29, 2023

Also, as part of the update, can you also prepare for docusaurus v3

@moyeah
Copy link
Contributor Author

moyeah commented Sep 29, 2023

@hamza1311 I will close this PR.
I made different PR per subject:

@moyeah moyeah closed this Sep 29, 2023
@moyeah moyeah deleted the update-docusaurus branch September 29, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranile ranile Awaiting requested review from ranile

1 more reviewer

@cecton cecton cecton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moyeah @ranile @cecton