Skip to content

Conversation

@jsjolund
Copy link
Contributor

Description

Improve grammar on the documentation website.

Checklist

  • I have reviewed my own code

@github-actions
Copy link

github-actions bot commented Jan 22, 2023

Visit the preview URL for this PR (updated for commit ca93c83):

https://yew-rs--pr3092-master-eol2v4yf.web.app

(expires Mon, 30 Jan 2023 11:59:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

It should have taken you a long time if you haven't used any automated grammar checker.

Some comments are not about the fixes but the original content itself.
I think it might be better to address them together in this pull request.

@jsjolund jsjolund force-pushed the master branch 2 times, most recently from 8cb79e1 to cfb089e Compare January 23, 2023 11:43
@jsjolund
Copy link
Contributor Author

Thanks for looking at it @futursolo, I added your changes to a commit.

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to go through the docs and improving them. Really appreciate the effort ❤️

I skimmed though and the changes look good. I'm going off of @futursolo's review and approving it.

If anything comes up, it can be fixed in a future PR, of course.

@ranile ranile merged commit 9556266 into yewstack:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants