Skip to content

Assert there are no circular references #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WorldSEnder merged 2 commits into from
Dec 10, 2022
Merged

Assert there are no circular references #3025

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55c0e09
assert there are no circular references
WorldSEnder Dec 10, 2022
111cb96
remove internal test for cyclic node refs
WorldSEnder Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/yew/src/html/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,10 @@ mod feat_csr {
/// Link a downstream `NodeRef`
pub(crate) fn link(&self, node_ref: Self) {
// Avoid circular references
if self == &node_ref {
return;
}
debug_assert!(
self != &node_ref,
"no circular references allowed! Report this as a bug in yew"
);

let mut this = self.0.borrow_mut();
this.node = None;
Expand Down