Skip to content

Add missing router docs: Redirect, Nested Router, and Path Segament capturing #2192

Merged
voidpumpkin merged 15 commits intoyewstack:masterfrom
Madoshakalaka:docs/nested-router
Nov 26, 2021
Merged

Add missing router docs: Redirect, Nested Router, and Path Segament capturing #2192
voidpumpkin merged 15 commits intoyewstack:masterfrom
Madoshakalaka:docs/nested-router

Conversation

@Madoshakalaka
Copy link
Member

@Madoshakalaka Madoshakalaka commented Nov 23, 2021 •
edited
Loading

Description

Fixes #2184
Fixes #2182
Fixes #2193

Checklist

  • I have run cargo make pr-flow
  • I have run cargo make lint (cargo make tests can't be run on Windows cuz firefox binary doesn't exist)
  • I have reviewed my own code
  • [NA] I have added tests

Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 281bbd6):

https://yew-rs--pr2192-docs-nested-router-8m2goep6.web.app

(expires Fri, 03 Dec 2021 03:46:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 23, 2021
View reviewed changes
@Madoshakalaka
Copy link
Member Author

Madoshakalaka commented Nov 23, 2021

This is touching router.md at the same time with PR #2188, but should not conflict each other as we touch different places (perhaps...)

@ranile
Copy link
Member

ranile commented Nov 23, 2021

This is touching router.md at the same time with PR #2188, but should not conflict each other as we touch different places (perhaps...)

That has been merged so feel free to merge the changes in this PR

@Madoshakalaka
Add redirect to nested router example
fe5657e 
normal component -> struct component
@voidpumpkin voidpumpkin enabled auto-merge (squash) November 24, 2021 08:09
@voidpumpkin voidpumpkin added A-yew-router Area: The yew-router crate documentation labels Nov 24, 2021
voidpumpkin
voidpumpkin requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for docs about #2193

auto-merge was automatically disabled November 24, 2021 09:26

Head branch was pushed to by a user without write access

Madoshakalaka
Madoshakalaka commented Nov 24, 2021
View reviewed changes
Madoshakalaka
Madoshakalaka commented Nov 24, 2021
View reviewed changes
@Madoshakalaka Madoshakalaka changed the title Add missing router docs: Redirect and Nested Router Add missing router docs: Redirect, Nested Router, and Path Segament capturing Nov 24, 2021
voidpumpkin
voidpumpkin requested changes Nov 24, 2021
View reviewed changes
ranile
ranile reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasn't the page grown too large? We should probably split the router page

@Madoshakalaka
reformat codeblock and the markdown
8e767f3 
functional comp -> function comp
consistent code snippet style
removed two ignores
@Madoshakalaka
add back ignores
a00a72a
@Madoshakalaka
Copy link
Member Author

Madoshakalaka commented Nov 25, 2021

Hasn't the page grown too large? We should probably split the router page

actually not the largest, currently comes after tutorial.md

\docs\tutorial.md 19081
\docs\concepts\router.md 15440
\docs\concepts\wasm-bindgen.md 12415
\docs\concepts\function-components\pre-defined-hooks.md 12136

What's your suggestion on the split though?

futursolo
futursolo reviewed Nov 25, 2021
View reviewed changes
@ranile
Copy link
Member

ranile commented Nov 25, 2021

What's your suggestion on the split though?

I don't know. I would just roll with it right now and look into it in the future

ranile
ranile requested changes Nov 25, 2021
View reviewed changes
@Madoshakalaka Madoshakalaka requested a review from ranile November 26, 2021 03:42
ranile
ranile approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ranile ranile self-requested a review November 26, 2021 03:52
ranile
ranile approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, did not mean to re-request my review

@voidpumpkin voidpumpkin enabled auto-merge (squash) November 26, 2021 08:00
@voidpumpkin voidpumpkin merged commit fd92ab8 into yewstack:master Nov 26, 2021
@voidpumpkin voidpumpkin mentioned this pull request Nov 26, 2021
Merged
3 tasks
@Madoshakalaka Madoshakalaka deleted the docs/nested-router branch November 30, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@futursolo futursolo futursolo left review comments

@voidpumpkin voidpumpkin voidpumpkin approved these changes

@ranile ranile ranile approved these changes

Assignees

No one assigned

Labels

A-yew-router Area: The yew-router crate documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Undocumented stateful route behaviour <Redirect/> is not documented Add docs for nested router

4 participants

@Madoshakalaka @ranile @futursolo @voidpumpkin