Remove extra braces in html_nested macro #2169
Conversation
|
@hamza1311 sorry for the repeated effort in #2167 , I initially marked the issue #2157 as |
| # test target can be optionally specified like `cargo make test html_macro`, | ||
| args = ["test", "${@}"] |
There was a problem hiding this comment.
I find this useful in development
|
|
||
| tokens.extend(quote_spanned! {ty.span()=> | ||
| { | ||
| #[allow(clippy::unit_arg)] |
There was a problem hiding this comment.
Previously the now __yew_props was inlined in the new call. When there are no properties (e.g. html_nested!{<MyComponent/>}), #build_props would return MyComponent::Properties::builder().build() which is the unit type, triggering the unit arg warning.
Extracting a variable solves that.
|
Can you also remove the |
voidpumpkin
added
A-yew-macro
| // can test "unused braces" warning inside the macro | ||
| // https://github.com/yewstack/yew/issues/2157 | ||
| fn make_my_component()-> ::yew::virtual_dom::VChild<MyComponent>{ | ||
| ::yew::html_nested!{<MyComponent/>} | ||
| } | ||
|
|
||
| // can test "unused braces" warning inside the macro | ||
| // https://github.com/yewstack/yew/issues/2157 | ||
| fn make_my_component_html()-> ::yew::Html{ | ||
| ::yew::html!{<MyComponent/>} | ||
| } |
There was a problem hiding this comment.
test for both html and html_nested
| fn to_tokens(&self, tokens: &mut TokenStream) { | ||
| let new_tokens = self.0.to_token_stream(); | ||
| tokens.extend(quote! {{ | ||
| #[allow(clippy::useless_conversion, unused_braces)] |
There was a problem hiding this comment.
this part is for the html! macro, it's no longer needed.
| } | ||
| } | ||
| TagName::Expr(name) => { | ||
| #[allow(unused_braces)] |
There was a problem hiding this comment.
Small correction in the html! marco. This is most likely misplaced. It does nothing here. No wonder, cuz the previous paragraphs repeated this pattern, this must have been copy-pasted here.
| #[allow(unused_braces)] | ||
| // e.g. html!{<@{"div"}/>} will set `#expr` to `{"div"}` | ||
| // (note the extra braces). Hence the need for the `allow`. | ||
| // Anyways to remove the braces? | ||
| let mut #vtag_name = ::std::convert::Into::< | ||
| ::std::borrow::Cow::<'static, ::std::primitive::str> | ||
| >::into(#expr); |
There was a problem hiding this comment.
This is where the misplaced #[allow] really belongs. Maybe the allow here is also liftable? I'm however too inexperienced with proc macro to figure it out. So I just left some comments instead
@hamza1311 done now :D |
mc1098
left a comment
mc1098
left a comment
There was a problem hiding this comment.
Seems more than fine to me 😏
* removed unused braces from html_nested marco * allow specifying test name * also fix for html! macro * also fix for html! macro * remove misplaced #[allow(unused_braces)] (cherry picked from commit 4c3d693)
4 participants
Description
Refactored the
html_nestedmacro to avoid extra bracesFixes #2157
Checklist
cargo make pr-flow