Allow taking Fn(EVENT) for callbacks too #1989
Merged
siku2 merged 4 commits intoyewstack:masterfrom Aug 9, 2021
Merged
Conversation
Member
Author
|
I'm not sure where the tests for this should go. This isn't macro related so |
Contributor
|
Nice workaround :) How about something like this in that #[test]
fn supported_into_event_callback_types() {
let f = |_: usize| ();
let cb = Callback::from(f);
// Callbacks
let _: Option<Callback<usize>> = cb.clone().into_event_callback();
let _: Option<Callback<usize>> = (&cb).into_event_callback();
let _: Option<Callback<usize>> = Some(cb).into_event_callback();
// Fns
let _: Option<Callback<usize>> = f.into_event_callback();
let _: Option<Callback<usize>> = Some(f).into_event_callback();
}Proves the supported types compile and the test passes :) |
4723fff to
a978a0a
Compare
mc1098
pushed a commit
to mc1098/yew
that referenced
this pull request
Aug 31, 2021
PR yewstack#1542 didn't merge in the changes from yewstack#1989 correctly, this is fixed in this commit.
2 tasks
siku2
pushed a commit
that referenced
this pull request
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new trait,
IntoEventCallback, to allowFn(EVENT)to be passed for listeners, in addition toCallback.This is workaround for specialization (or lack thereof) and should be removed once specialization hits.
Fixes #1657 (the main problem described)
Checklist
cargo make pr-flow