Skip to content

Conversation

@bakape
Copy link
Contributor

@bakape bakape commented May 22, 2021

Description

Fixes regression introduced in v0.17.4 -> v0.18.0, whereby you can no longer set the autoplay attribute, as it requires a boolean value but expands into a call to PositionalAttr::new() instead of PositionalAttr::new_boolean(), resulting in the following error:

autoplay=true
         ^^^^ the trait `IntoPropValue<std::option::Option<Cow<'static, str>>>` is not implemented for `bool`

After this passes, I will check if master is affected and merge + PR, if needed.

Checklist

  • I have run cargo make pr-flow (test fail even on unmodified v0.18 for me; lets see what the CI will say)
  • I have reviewed my own code
  • I have added tests (extended one)

@bakape
Copy link
Contributor Author

bakape commented May 22, 2021

Only nightly tests failed, so seems to be fine.

@siku2 siku2 merged commit cf4ed4b into yewstack:v0.18 May 22, 2021
ranile pushed a commit to ranile/yew that referenced this pull request Jun 5, 2021
ranile pushed a commit to ranile/yew that referenced this pull request Jun 5, 2021
@voidpumpkin voidpumpkin added the A-yew-macro Area: The yew-macro crate label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew-macro Area: The yew-macro crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants