Skip to content

Conversation

@philip-peterson
Copy link
Contributor

Description

After discussion with Simon, we concluded that the CRM example doesn't show anything of particular note other than the custom routing mechanism which likely isn't advisable with yew-router in existence. So, I removed that example. Additionally since we needed an example like #1465 that demonstrated controlled components, this PR introduces a new example app which features a password strength estimator.

pwgen2.mov

To Do:

  • write a README

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@siku2 siku2 added the A-examples Area: The examples label Feb 23, 2021
@siku2
Copy link
Member

siku2 commented May 5, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Command update: failure

Base branch update has failed
merge conflict between base and head
err-code: 5443A

@siku2
Copy link
Member

siku2 commented May 5, 2021

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Command rebase: failure

Base branch update has failed
Git reported the following error:

First, rewinding head to replay your work on top of it...
Applying: Remove crm example
Using index info to reconstruct a base tree...
M	Cargo.toml
M	examples/crm/Cargo.toml
M	examples/crm/README.md
M	examples/crm/src/main.rs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): examples/crm/src/main.rs deleted in Remove crm example and modified in HEAD. Version HEAD of examples/crm/src/main.rs left in tree.
Removing examples/crm/src/add_client.rs
Removing examples/crm/index.html
CONFLICT (modify/delete): examples/crm/README.md deleted in Remove crm example and modified in HEAD. Version HEAD of examples/crm/README.md left in tree.
CONFLICT (modify/delete): examples/crm/Cargo.toml deleted in Remove crm example and modified in HEAD. Version HEAD of examples/crm/Cargo.toml left in tree.
Auto-merging Cargo.toml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 Remove crm example
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

err-code: 9B1F4

@mc1098
Copy link
Contributor

mc1098 commented Sep 25, 2021

Hi @philip-peterson 👋,

Are you still working on this PR?

I'm happy to review it once the conflicts are resolved, there have been lots of changes to Yew after all :)
If I don't hear from you, I will assume you are unable to continue the PR and close it on your behalf.

Happy coding ❤️

@mc1098 mc1098 added the S-waiting-on-author Status: awaiting action from the author of the issue/PR label Sep 25, 2021
@philip-peterson
Copy link
Contributor Author

@mc1098 I can rebase this PR if you can approve/merge it once it’s ready. I’m pretty sure it was ready before but just got neglected and now it has merge conflicts so I would rather not repeat that loop.

@mc1098 mc1098 removed the S-waiting-on-author Status: awaiting action from the author of the issue/PR label Sep 25, 2021
@siku2
Copy link
Member

siku2 commented Sep 25, 2021

I’m pretty sure it was ready before but just got neglected and now it has merge conflicts so I would rather not repeat that loop.

Sorry about that, that was on me! I promise it won't happen again (at least not with this PR :P).

@mc1098
Copy link
Contributor

mc1098 commented Sep 25, 2021

@mc1098 I can rebase this PR if you can approve/merge it once it’s ready. I’m pretty sure it was ready before but just got neglected and now it has merge conflicts so I would rather not repeat that loop.

Once you've rebased and resolved the conflicts then I will happily review it as soon as I can! If all is good then I can approve it :) After I approve it then I'll happily also take ownership over it so that it gets over the finish line too 🎉

@voidpumpkin voidpumpkin force-pushed the peterson/password-strength branch from 0ed3b1b to 72eb3dc Compare November 20, 2021 17:40
@voidpumpkin
Copy link
Member

@siku2 If we want this to be merged still, I updated it

@voidpumpkin voidpumpkin requested a review from siku2 November 20, 2021 17:41
@voidpumpkin
Copy link
Member

@mc1098 Time to return the second pair of eyes

@voidpumpkin voidpumpkin enabled auto-merge (squash) November 20, 2021 19:43
@voidpumpkin voidpumpkin merged commit 1f03a04 into yewstack:master Nov 20, 2021
@voidpumpkin
Copy link
Member

@mc1098 nvm :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-examples Area: The examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants