-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Replace crm example with password strength to show controlled components
#1706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crm example with password strength to show controlled components
#1706
Conversation
|
@Mergifyio update |
|
Command
|
|
@Mergifyio rebase |
|
Command
|
|
Hi @philip-peterson 👋, Are you still working on this PR? I'm happy to review it once the conflicts are resolved, there have been lots of changes to Yew after all :) Happy coding ❤️ |
|
@mc1098 I can rebase this PR if you can approve/merge it once it’s ready. I’m pretty sure it was ready before but just got neglected and now it has merge conflicts so I would rather not repeat that loop. |
Sorry about that, that was on me! I promise it won't happen again (at least not with this PR :P). |
Once you've rebased and resolved the conflicts then I will happily review it as soon as I can! If all is good then I can approve it :) After I approve it then I'll happily also take ownership over it so that it gets over the finish line too 🎉 |
0ed3b1b to
72eb3dc
Compare
|
@siku2 If we want this to be merged still, I updated it |
|
@mc1098 Time to return the second pair of eyes |
|
@mc1098 nvm :D |
Description
After discussion with Simon, we concluded that the CRM example doesn't show anything of particular note other than the custom routing mechanism which likely isn't advisable with yew-router in existence. So, I removed that example. Additionally since we needed an example like #1465 that demonstrated controlled components, this PR introduces a new example app which features a password strength estimator.
pwgen2.mov
To Do:
Checklist
cargo make pr-flow