Improve the "keyed_list" example#1650
Merged
siku2 merged 10 commits intoyewstack:masterfrom Nov 22, 2020
Merged
Conversation
| </div> | ||
| <p>{ "Number of persons: " }{ self.persons.len() }</p> | ||
| <p>{ "Ids: " }{ ids }</p> | ||
| <p class="h5">{ "Number of persons: " }{ self.persons.len() }</p> |
Contributor
There was a problem hiding this comment.
I guess this depends on which version of English you use.
Suggested change
| <p class="h5">{ "Number of persons: " }{ self.persons.len() }</p> | |
| <p class="h5">{ "Number of people: " }{ self.persons.len() }</p> |
Contributor
Author
There was a problem hiding this comment.
Not sure here, I leave it unchanged temporarily.
Co-authored-by: Teymour Aldridge <[email protected]>
siku2
reviewed
Nov 21, 2020
Member
siku2
left a comment
siku2
left a comment
There was a problem hiding this comment.
The example looks great, love the use of the fake crate to generate better data!
Contributor
Author
|
Already updated the code, please check |
siku2
reviewed
Nov 22, 2020
Member
siku2
left a comment
siku2
left a comment
There was a problem hiding this comment.
Looking good, just a few more formatting issues.
siku2
approved these changes
Nov 22, 2020
Member
siku2
left a comment
siku2
left a comment
There was a problem hiding this comment.
Great, thanks a lot!
Our automatic deployment to examples.yew.rs broke a few days ago and I want to fix that before merging this. There's nothing you need to do though, just a heads up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aim to improve all possible improvements listed in the README.
This work is done by adding new crate and bootstrap css template, not sure is it suitable or not, but I'm pretty sure the time duration is valid task (takes me LOTS of time).
Not a professional UI designer, I try my best to decorate the prior example.
Still new in Yew and Rust, hope this PR will help everyone.
Checklist
cargo make pr-flow