Improve error messages for invalid fragments#1445
Merged
siku2 merged 4 commits intoyewstack:masterfrom Jul 26, 2020
Merged
Conversation
Member
Author
|
@alexschrod Would you mind looking at the new error messages to see if they match your expectations? |
Contributor
|
Looks good to me, @siku2 |
jstarry
reviewed
Jul 26, 2020
jstarry
approved these changes
Jul 26, 2020
Member
jstarry
left a comment
jstarry
left a comment
There was a problem hiding this comment.
What difference did using the proc_macro2 token stream make?
Member
Author
|
@jstarry The reason I made that change is because |
jstarry
pushed a commit
that referenced
this pull request
Aug 16, 2020
* remove specific version from "stable" check * update sterr to new rust stable * improve html list error messages * run trybuild tests for 1.45
teymour-aldridge
pushed a commit
to teymour-aldridge/yew
that referenced
this pull request
Sep 1, 2020
* remove specific version from "stable" check * update sterr to new rust stable * improve html list error messages * run trybuild tests for 1.45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
That took a lot more time than I expected...
Fixes #1444
Checklist:
./ci/run_stable_checks.sh