Skip to content

Implement PartialEq for VChild#1242

Merged
jstarry merged 2 commits intoyewstack:masterfrom
kellpossible:vchild-partialeq
May 17, 2020
Merged

Implement PartialEq for VChild#1242
jstarry merged 2 commits intoyewstack:masterfrom
kellpossible:vchild-partialeq

Conversation

@kellpossible
Copy link
Contributor

@kellpossible kellpossible commented May 17, 2020

Fixes #1216

Implement PartialEq trait for VChild just by comparing the Component::Properties when they themselves implement PartialEq.

jstarry
jstarry previously approved these changes May 17, 2020
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Before merging, can you run cargo fmt?

@mergify mergify bot dismissed jstarry’s stale review May 17, 2020 15:22

Pull request has been modified.

@jstarry jstarry merged commit 5b0ecc0 into yewstack:master May 17, 2020
@kellpossible kellpossible deleted the vchild-partialeq branch May 18, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement PartialEq for VChild

2 participants