Improve html! error messages.#1192
Merged
jstarry merged 13 commits intoyewstack:masterfrom May 10, 2020
Merged
Conversation
Member
|
yay for enjoyable debugging 🎉 FYI you'll probably find this useful for making CI happy: https://github.com/yewstack/yew/blob/master/CONTRIBUTING.md#macro-tests |
Contributor
Author
|
Thanks for the link!
… On 9 May 2020, at 14:25, Justin Starry ***@***.***> wrote:
yay for enjoyable debugging 🎉
FYI you'll probably find this useful for making CI happy: https://github.com/yewstack/yew/blob/master/CONTRIBUTING.md#macro-tests <https://github.com/yewstack/yew/blob/master/CONTRIBUTING.md#macro-tests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFSTPII3CXJXZ4SKBPQRZLRQVKVJANCNFSM4M4ZH2IQ>.
|
Contributor
Author
|
Not sure why it's only working on Rust |
Contributor
Author
|
Seems to be a problem with the change from "expected expression" to "expected an expression." |
Member
|
@teymour-aldridge the rust version will change the output since it depends on the compiler error messages. For this reason, we only run these macro tests on latest stable (they are not run on |
Contributor
Author
|
Ah, thanks! |
Contributor
Author
|
I think I've now resolved this. |
jstarry
pushed a commit
that referenced
this pull request
May 14, 2020
* Improve `html!` error messages. * Improved some additional error messages. * Improved error messages for iterables. * Improved list error messages. * Made a comment clearer. * Updated an `html_tag` error message. * Improved duplicate attribute error message. * Updated tests to reflect updated error messages. * Reformat code. * Updated tests to reflect new error messages. * Updated macro tests. * Fix macro tests. * Reformat code.
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2020
* Improve `html!` error messages. * Improved some additional error messages. * Improved error messages for iterables. * Improved list error messages. * Made a comment clearer. * Updated an `html_tag` error message. * Improved duplicate attribute error message. * Updated tests to reflect updated error messages. * Reformat code. * Updated tests to reflect new error messages. * Updated macro tests. * Fix macro tests. * Reformat code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this makes the debugging experience smoother and more enjoyable.