Split class names on whitespace when using tuple or Vec#1084
Merged
jstarry merged 3 commits intoyewstack:masterfrom Apr 14, 2020
Merged
Split class names on whitespace when using tuple or Vec#1084jstarry merged 3 commits intoyewstack:masterfrom
tuple or Vec#1084jstarry merged 3 commits intoyewstack:masterfrom
Conversation
When creating a `VTag` with `class` assigned from a `Vec` the items in `Vec` were not split on whitespace and so were not enforced as unique in the same way a `VTag` with `class` assigned from `tuple`.
jstarry
approved these changes
Apr 14, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Classes::pushto use the existingFrom<&str> for Classesimplementation which usesstr::split_whitespace. Theimpl<T: AsRef<str>> From<Vec<T>> for Classeshas likewise been changed to usestr::split_whitespaceon each of the members of the incomingVec.Add tests to cover the new expected behavior of the functions related to the
Classesstruct.Fixes #935