Handle [type] attribute on the Button element#1033
Conversation
|
@captain-yossarian I think it's unlikely that stdweb will update. Do you mind implementing this for |
|
Sure, I will do it at the weekend |
yew/src/virtual_dom/vtag.rs
Outdated
| // TODO: add std_web after https://github.com/koute/stdweb/issues/395 will be approved | ||
| // Check this out: https://github.com/yewstack/yew/pull/1033/commits/4b4e958bb1ccac0524eb20f63f06ae394c20553d | ||
| cfg_match! { | ||
| feature = "web_sys" => element.dyn_ref::<HtmlButtonElement>(), |
There was a problem hiding this comment.
@captain-yossarian you need to make sure your code works for stdweb:
(cd yew-stdweb && cargo check)|
@jstarry @teymour-aldridge |
|
@captain-yossarian I don't think that's the problem. I think the |
@teymour-aldridge Should I have minimum 2 conditions inside cfg_match ? I'm not so experienced rustacean :) to read source code of cdf_match macro |
|
I'm not sure. What happens if you just use |
|
@captain-yossarian Have you been able to fix it? |
|
@teymour-aldridge Unfortunately, no |
|
Thanks @captain-yossarian! I fixed up the |
|
@jstarry Wow, thanks. I did not know we can apply #[cfg(feature = "web_sys")] to code blocks ) |
|
You're welcome! Hope someday we can apply it to |
Relates to #750
Fixes: #1252