Treat some references differently for ergonomics#13
Open
kirillsemyonkin wants to merge 1 commit intoyewstack:mainfrom
Open
Treat some references differently for ergonomics#13kirillsemyonkin wants to merge 1 commit intoyewstack:mainfrom
kirillsemyonkin wants to merge 1 commit intoyewstack:mainfrom
Conversation
Collaborator
Author
|
I'm not going to fix MSRV - I do not know what's the intent behind the chosen MSRV and such unspecific versions in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered by @Madoshakalaka
If a reference type is actually intended,
#[autoprops]will currently ignore that and put a referenceless type into the props struct. For example:In this case
'staticis ignored, andstris attempted to be put into props struct. As a workaround, currently works:But it is unergonomic. It is well known that reference is wanted (by the lifetime specifier existing), so let's put such references into props struct as-is.