Skip to content

Fix XML External Entity (XXE) Vulnerability in XML Processing #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix XML External Entity (XXE) Vulnerability in XML Processing #1406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/main/java/org/takes/rs/xe/RsXembly.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,20 @@ private static InputStream render(final Node dom,
return new ByteArrayInputStream(baos.toByteArray());
}

/**
* Create empty DOM Document.
* @return Document
*/
private static Document emptyDocument() {
private static Document emptyDocument() {
try {
return DocumentBuilderFactory.newInstance()
.newDocumentBuilder()
.newDocument();
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();

// Disable external entity processing to prevent XXE attacks
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, "");
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");

// For enhanced security, also consider:
factory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
factory.setXIncludeAware(false);
factory.setExpandEntityReferences(false);

return factory.newDocumentBuilder().newDocument();
} catch (final ParserConfigurationException ex) {
throw new IllegalStateException(
"Could not instantiate DocumentBuilderFactory and build empty Document",
Expand Down
Loading