Skip to content

Try to rewrite gracejoin in peephole instead of creating blockhashjoi… #21015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lll-phill-lll
Copy link
Member

…n in dq_opt_join

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link

github-actions bot commented Jul 11, 2025

2025-07-11 17:38:19 UTC Pre-commit check linux-x86_64-release-asan for 5661705 has started.
2025-07-11 17:38:33 UTC Artifacts will be uploaded here
2025-07-11 17:42:01 UTC ya make is running...
🟡 2025-07-11 19:50:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14647 14154 0 267 201 25

🟢 2025-07-11 19:52:00 UTC Build successful.
🟢 2025-07-11 19:52:30 UTC ydbd size 3.9 GiB changed* by -196.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2378fba merge: 5661705 diff diff %
ydbd size 4 204 668 152 Bytes 4 204 467 008 Bytes -196.4 KiB -0.005%
ydbd stripped size 1 458 020 376 Bytes 1 457 949 048 Bytes -69.7 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2025

2025-07-11 17:38:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5661705 has started.
2025-07-11 17:38:39 UTC Artifacts will be uploaded here
2025-07-11 17:42:01 UTC ya make is running...
🟡 2025-07-11 19:24:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37059 34317 0 3 2696 43

2025-07-11 19:28:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-11 19:41:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
485 (only retried tests) 449 0 0 2 34

🟢 2025-07-11 19:41:11 UTC Build successful.
🟢 2025-07-11 19:41:31 UTC ydbd size 2.2 GiB changed* by -44.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2378fba merge: 5661705 diff diff %
ydbd size 2 390 055 336 Bytes 2 390 010 112 Bytes -44.2 KiB -0.002%
ydbd stripped size 500 629 480 Bytes 500 619 688 Bytes -9.6 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-07-11 17:38:49 UTC The validation of the Pull Request description is successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant