-
Notifications
You must be signed in to change notification settings - Fork 696
YQ-20669-i fixed external sources ddl errors #20670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ-20669-i fixed external sources ddl errors #20670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes DDL errors for external sources by improving test coverage for drop operations and enhancing error messages with operation context.
- Updated unit tests to validate specific error substrings for drop table/source operations.
- Enhanced error reporting in
SendSchemeRequest
andKqpSchemeExecuter
to include the operation type in failure messages. - Added a new peer dependency on
schemeshard/operations.pb.h
in the build.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp | Extended checkNotFound to accept and assert an extra error string |
ydb/core/kqp/gateway/utils/ya.make | Added ydb/core/protos/schemeshard to the peer directories |
ydb/core/kqp/gateway/utils/metadata_helpers.cpp | Enhanced SendSchemeRequest error messages with operation type |
ydb/core/kqp/executer_actor/kqp_scheme_executer.cpp | Wrapped future results to include operation type context |
🟢 |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fixed external sources ddl errors, also fix for: #20669
Changelog category
Description for reviewers