Skip to content

YQ-20669-i fixed external sources ddl errors #20670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed external sources ddl errors, also fix for: #20669

Changelog category

  • Bugfix

Description for reviewers

@GrigoriyPA GrigoriyPA requested a review from Hor911 July 5, 2025 10:42
@GrigoriyPA GrigoriyPA requested a review from a team as a code owner July 5, 2025 10:42
@GrigoriyPA
Copy link
Collaborator Author

#20669

@github-actions github-actions bot added the bugfix label Jul 5, 2025
@GrigoriyPA GrigoriyPA requested a review from Copilot July 5, 2025 10:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes DDL errors for external sources by improving test coverage for drop operations and enhancing error messages with operation context.

  • Updated unit tests to validate specific error substrings for drop table/source operations.
  • Enhanced error reporting in SendSchemeRequest and KqpSchemeExecuter to include the operation type in failure messages.
  • Added a new peer dependency on schemeshard/operations.pb.h in the build.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp Extended checkNotFound to accept and assert an extra error string
ydb/core/kqp/gateway/utils/ya.make Added ydb/core/protos/schemeshard to the peer directories
ydb/core/kqp/gateway/utils/metadata_helpers.cpp Enhanced SendSchemeRequest error messages with operation type
ydb/core/kqp/executer_actor/kqp_scheme_executer.cpp Wrapped future results to include operation type context

Copy link

github-actions bot commented Jul 5, 2025

🟢 2025-07-05 10:44:50 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jul 5, 2025

2025-07-05 10:45:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 54ce71d has started.
2025-07-05 10:45:52 UTC Artifacts will be uploaded here
2025-07-05 10:49:07 UTC ya make is running...
🟡 2025-07-05 11:49:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29273 27861 0 7 1362 43

2025-07-05 11:52:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-05 11:58:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
397 (only retried tests) 356 0 1 2 38

2025-07-05 11:59:08 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-05 12:05:34 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
219 (only retried tests) 178 0 1 2 38

🟢 2025-07-05 12:05:41 UTC Build successful.
🟢 2025-07-05 12:06:02 UTC ydbd size 2.2 GiB changed* by +22.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 54ce71d diff diff %
ydbd size 2 387 865 384 Bytes 2 387 888 024 Bytes +22.1 KiB +0.001%
ydbd stripped size 499 603 048 Bytes 499 610 280 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2025

2025-07-05 10:45:43 UTC Pre-commit check linux-x86_64-release-asan for 54ce71d has started.
2025-07-05 10:45:54 UTC Artifacts will be uploaded here
2025-07-05 10:49:06 UTC ya make is running...
🟡 2025-07-05 12:29:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14118 13770 0 124 195 29

🟢 2025-07-05 12:30:39 UTC Build successful.
🟢 2025-07-05 12:31:06 UTC ydbd size 3.9 GiB changed* by +26.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 54ce71d diff diff %
ydbd size 4 200 002 176 Bytes 4 200 029 680 Bytes +26.9 KiB +0.001%
ydbd stripped size 1 455 233 272 Bytes 1 455 239 480 Bytes +6.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2025

2025-07-05 13:27:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8024be5 has started.
2025-07-05 13:28:08 UTC Artifacts will be uploaded here
2025-07-05 13:31:25 UTC ya make is running...
🟡 2025-07-05 14:29:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29273 27867 0 2 1360 44

2025-07-05 14:32:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-05 14:43:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
230 (only retried tests) 189 0 0 2 39

🟢 2025-07-05 14:43:19 UTC Build successful.
🟢 2025-07-05 14:43:37 UTC ydbd size 2.2 GiB changed* by +22.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 8024be5 diff diff %
ydbd size 2 387 865 384 Bytes 2 387 888 024 Bytes +22.1 KiB +0.001%
ydbd stripped size 499 603 048 Bytes 499 610 280 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2025

2025-07-05 13:28:15 UTC Pre-commit check linux-x86_64-release-asan for 8024be5 has started.
2025-07-05 13:28:26 UTC Artifacts will be uploaded here
2025-07-05 13:31:45 UTC ya make is running...
🟡 2025-07-05 15:17:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14118 13653 0 219 212 34

🟢 2025-07-05 15:18:42 UTC Build successful.
🟢 2025-07-05 15:19:14 UTC ydbd size 3.9 GiB changed* by +26.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 8024be5 diff diff %
ydbd size 4 200 002 176 Bytes 4 200 029 680 Bytes +26.9 KiB +0.001%
ydbd stripped size 1 455 233 272 Bytes 1 455 239 480 Bytes +6.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant