Skip to content

Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) #20665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) #20665

wants to merge 3 commits into from

Conversation

vitalif
Copy link
Collaborator

@vitalif vitalif commented Jul 4, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@vitalif vitalif requested a review from a team as a code owner July 4, 2025 17:52
@vitalif vitalif linked an issue Jul 4, 2025 that may be closed by this pull request
Something with vector indexes leads to YDB docker crash #20501
Open
@vitalif vitalif requested a review from kunga July 4, 2025 17:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

⚪ 2025-07-04 17:54:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 972e172 has started.
⚪ 2025-07-04 17:55:08 UTC Artifacts will be uploaded here
⚪ 2025-07-04 17:59:13 UTC ya make is running...
🟡 2025-07-04 19:04:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29668 28257 0 1 1366 44

⚪ 2025-07-04 19:06:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-04 19:17:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
348 (only retried tests) 301 0 0 9 38

🟢 2025-07-04 19:17:40 UTC Build successful.
🟢 2025-07-04 19:17:59 UTC ydbd size 2.2 GiB changed* by +368 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 972e172 diff diff %
ydbd size 2 387 865 384 Bytes 2 387 865 752 Bytes +368 Bytes +0.000%
ydbd stripped size 499 603 048 Bytes 499 603 240 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025

🟢 2025-07-04 17:55:28 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

⚪ 2025-07-04 17:57:10 UTC Pre-commit check linux-x86_64-release-asan for 972e172 has started.
⚪ 2025-07-04 17:57:21 UTC Artifacts will be uploaded here
⚪ 2025-07-04 18:00:32 UTC ya make is running...
🟡 2025-07-04 19:42:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14281 13938 0 119 195 29

🟢 2025-07-04 19:43:22 UTC Build successful.
🟢 2025-07-04 19:43:50 UTC ydbd size 3.9 GiB changed* by +576 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 972e172 diff diff %
ydbd size 4 200 002 176 Bytes 4 200 002 752 Bytes +576 Bytes +0.000%
ydbd stripped size 1 455 233 272 Bytes 1 455 233 656 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

azevaykin
azevaykin reviewed Jul 5, 2025
View reviewed changes
ydb/core/tx/schemeshard/ut_move/ut_move.cpp
TestDescribeResult(DescribePrivatePath(runtime, "/MyRoot/Table/index1/indexImplPrefixTable"),
{ NLs::PathExist, NLs::CheckColumns(PrefixTable, {"prefix", IdColumn}, {}, {"prefix", IdColumn}, true) });

// Replace again - it previously crashed here when Dec/IncAliveChildren were incorrect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для будущих поколений это не несет информации

Suggested change
// Replace again - it previously crashed here when Dec/IncAliveChildren were incorrect
// Replace again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azevaykin azevaykin azevaykin left review comments

@kunga kunga Awaiting requested review from kunga

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something with vector indexes leads to YDB docker crash
2 participants
@vitalif @azevaykin