Skip to content

duplicate filter tmp 1 #20648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

duplicate filter tmp 1 #20648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7aab53d
column fetching with caching
swalrus1 Jul 2, 2025
f7499cf
pass cookie, remove context
swalrus1 Jul 3, 2025
f286ed6
fix
swalrus1 Jul 3, 2025
98d36f6
fix
swalrus1 Jul 3, 2025
bd588a5
fix
swalrus1 Jul 4, 2025
3023bd6
wip
swalrus1 Jul 4, 2025
0f3f7ad
fix
swalrus1 Jul 7, 2025
9211935
rebase
swalrus1 Jul 7, 2025
5312027
rebase
swalrus1 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ydb/core/formats/arrow/rows/view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ std::partial_ordering TSimpleRow::operator<=>(const TSimpleRow& item) const {
return TSimpleRowViewV0(Data).Compare(TSimpleRowViewV0(item.Data), Schema).GetResult();
}

bool TSimpleRow::operator==(const TSimpleRow& item) const {
return (*this <=> item) == std::partial_ordering::equivalent;
}

std::shared_ptr<arrow::RecordBatch> TSimpleRow::ToBatch() const {
auto builders = NArrow::MakeBuilders(Schema);
AddToBuilders(builders).Validate();
Expand Down
1 change: 1 addition & 0 deletions ydb/core/formats/arrow/rows/view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ class TSimpleRow {
std::partial_ordering CompareNotNull(const TSimpleRow& item) const;

std::partial_ordering operator<=>(const TSimpleRow& item) const;
bool operator==(const TSimpleRow& item) const;
};

} // namespace NKikimr::NArrow
2 changes: 2 additions & 0 deletions ydb/core/kqp/ut/common/kqp_ut_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,14 @@ struct TKikimrSettings: public TTestFeatureFlagsHolder<TKikimrSettings> {
exchangerSettings->SetMaxDelayMs(10);
AppConfig.MutableColumnShardConfig()->SetDisabledOnSchemeShard(false);
AppConfig.MutableColumnShardConfig()->SetMaxInFlightIntervalsOnRequest(1);
AppConfig.MutableColumnShardConfig()->SetAlterObjectEnabled(true);
FeatureFlags.SetEnableSparsedColumns(true);
FeatureFlags.SetEnableWritePortionsOnInsert(true);
FeatureFlags.SetEnableParameterizedDecimal(true);
FeatureFlags.SetEnableTopicAutopartitioningForCDC(true);
FeatureFlags.SetEnableFollowerStats(true);
FeatureFlags.SetEnableColumnStore(true);
FeatureFlags.SetEnableDuplicateFilterInColumnShard(true);
}

TKikimrSettings& SetAppConfig(const NKikimrConfig::TAppConfig& value) { AppConfig = value; return *this; }
Expand Down
4 changes: 3 additions & 1 deletion ydb/core/kqp/ut/olap/aggregations_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ Y_UNIT_TEST_SUITE(KqpOlapAggregations) {
}

{
WriteTestData(kikimr, "/Root/olapStore/olapTable", 10000, 3000000, 1000);
WriteTestData(kikimr, "/Root/olapStore/olapTable", 10000, 3000000, 1000);
WriteTestData(kikimr, "/Root/olapStore/olapTable", 10000, 3000000, 1000);
WriteTestData(kikimr, "/Root/olapStore/olapTable", 11000, 3001000, 1000);
WriteTestData(kikimr, "/Root/olapStore/olapTable", 12000, 3002000, 1000);
Expand Down Expand Up @@ -99,7 +101,7 @@ Y_UNIT_TEST_SUITE(KqpOlapAggregations) {
UNIT_ASSERT_C(it.IsSuccess(), it.GetIssues().ToString());
TString result = StreamResultToYson(it);
Cout << result << Endl;
CompareYson(result, R"([[23000u;]])");
CompareYson(result, R"([[25000u;]])");
}
}

Expand Down
Loading
Loading