Skip to content

#9056 Complete column names in YDB CLI #19918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2025

Conversation

vityaman
Copy link
Contributor

@vityaman vityaman commented Jun 19, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Complete column names in YDB CLI

Implemented DescribeTable using the YDB Client. Now supported only SELECT a| FROM table_name. SELECT | FROM table_name is not working because of current limitations of the completion engine (it interprets FROM as a column name and then fails to parse a table name after from), so at least one letter of column name is required. Also SELECT p.a| FROM table_name AS p is working.

Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

Copy link

github-actions bot commented Jun 19, 2025

🟢 2025-06-26 18:44:16 UTC The validation of the Pull Request description is successful.

@vityaman vityaman force-pushed the YQL-19747-describe-table branch from 973c4d3 to 8787a5d Compare June 21, 2025 05:03
@vityaman vityaman marked this pull request as ready for review June 21, 2025 05:07
@vityaman vityaman requested a review from a team as a code owner June 21, 2025 05:07
@vityaman
Copy link
Contributor Author

@pnv1, the PR is ready for a review.

@vityaman vityaman requested a review from a team as a code owner June 21, 2025 07:34
@vityaman vityaman force-pushed the YQL-19747-describe-table branch from 7e2f9c4 to 91a7764 Compare June 24, 2025 14:04
@vityaman vityaman force-pushed the YQL-19747-describe-table branch from 0e8907d to a72afbf Compare June 26, 2025 16:44
@pnv1 pnv1 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Jun 26, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Jun 26, 2025
@pnv1 pnv1 removed the request for review from a team June 26, 2025 20:34
Copy link

github-actions bot commented Jun 26, 2025

2025-06-26 20:37:32 UTC Pre-commit check linux-x86_64-release-asan for 00a15c5 has started.
2025-06-26 20:37:45 UTC Artifacts will be uploaded here
2025-06-26 20:40:12 UTC ya make is running...
🟡 2025-06-26 21:20:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1376 1247 0 13 110 6

🟢 2025-06-26 21:20:24 UTC Build successful.
🟢 2025-06-26 21:20:40 UTC ydbd size 3.9 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 935b735 merge: 00a15c5 diff diff %
ydbd size 4 193 756 216 Bytes 4 193 756 120 Bytes -96 Bytes -0.000%
ydbd stripped size 1 453 748 792 Bytes 1 453 748 728 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 26, 2025

2025-06-26 20:38:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 00a15c5 has started.
2025-06-26 20:38:46 UTC Artifacts will be uploaded here
2025-06-26 20:41:21 UTC ya make is running...
🟢 2025-06-26 20:58:55 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2156 2143 0 0 9 4

🟢 2025-06-26 20:59:12 UTC Build successful.
🟢 2025-06-26 20:59:23 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 935b735 merge: 00a15c5 diff diff %
ydbd size 2 383 680 216 Bytes 2 383 680 216 Bytes 0 Bytes 0.000%
ydbd stripped size 499 053 288 Bytes 499 053 288 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 merged commit 26e438e into ydb-platform:main Jun 27, 2025
17 checks passed
@vityaman vityaman deleted the YQL-19747-describe-table branch June 27, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants