Skip to content

Added processing sys view path type in GRPC handlers #19030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Added processing sys view path type in GRPC handlers #19030

merged 1 commit into from
May 30, 2025

Conversation

n00bcracker
Copy link
Collaborator

This PR is one from the row to support new system view path type all around YDB.
In previous PRs I added this new type. In the future we want to remove SystemViewInfo field from TableId and use the kind of Navigate entry to process only system view paths.
In this PR:

  • updated conditions where we check whether the Navigate entry is system view or not
  • added new Entry type in ydb_scheme proto to support describe path and table RPC requests

@n00bcracker n00bcracker linked an issue May 29, 2025 that may be closed by this pull request
Support system view path type in GRPC handlers #18896
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 15:23:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3aaa430 has started.
⚪ 2025-05-29 15:24:07 UTC Artifacts will be uploaded here
⚪ 2025-05-29 15:28:23 UTC ya make is running...
🟡 2025-05-29 17:24:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31378 28686 0 6 2653 33

⚪ 2025-05-29 17:27:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-29 18:06:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
574 (only retried tests) 544 0 0 0 30

🟢 2025-05-29 18:06:18 UTC Build successful.
🔴 2025-05-29 18:06:38 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 3aaa430 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 413 704 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 025 000 Bytes +619.2 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 15:25:33 UTC Pre-commit check linux-x86_64-release-asan for 3aaa430 has started.
⚪ 2025-05-29 15:26:03 UTC Artifacts will be uploaded here
⚪ 2025-05-29 15:29:59 UTC ya make is running...
🟡 2025-05-29 17:43:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16355 16157 0 95 77 26

⚪ 2025-05-29 17:44:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 18:18:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1592 (only retried tests) 1494 0 53 23 22

⚪ 2025-05-29 18:19:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 18:47:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1303 (only retried tests) 1221 0 49 10 23

🟢 2025-05-29 18:47:42 UTC Build successful.
🔴 2025-05-29 18:48:14 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 3aaa430 diff diff %
ydbd size 4 147 273 176 Bytes 4 154 916 312 Bytes +7.3 MiB +0.184%
ydbd stripped size 1 440 065 016 Bytes 1 442 218 200 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

🟢 2025-05-29 15:26:06 UTC The validation of the Pull Request description is successful.

@n00bcracker n00bcracker marked this pull request as ready for review May 29, 2025 21:39
@n00bcracker n00bcracker requested a review from azevaykin May 29, 2025 21:39
azevaykin
azevaykin reviewed May 30, 2025
View reviewed changes
@n00bcracker n00bcracker requested a review from azevaykin May 30, 2025 07:03
@n00bcracker n00bcracker merged commit cde1dc2 into ydb-platform:main May 30, 2025
17 checks passed
@n00bcracker n00bcracker deleted the grpc_handlers_sysview_pathtype_support branch May 30, 2025 08:34
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@n00bcracker
Added processing sys view path type in GRPC handlers (ydb-platform#19030
14bb43a 
)
@n00bcracker n00bcracker mentioned this pull request Jun 20, 2025
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azevaykin azevaykin azevaykin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support system view path type in GRPC handlers
2 participants
@n00bcracker @azevaykin