-
Notifications
You must be signed in to change notification settings - Fork 699
YQ-4317 PQ provider to ydb #18955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-4317 PQ provider to ydb #18955
Conversation
⚪ |
⚪ |
🟢 |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
🔴 Unable to merge your PR into the base branch. Please rebase or merge it with the base branch. |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/config/ut/main.cpp
Outdated
@@ -274,6 +274,15 @@ Y_UNIT_TEST_SUITE(ConfigProto) { | |||
"/AppConfig/QueryServiceConfig/Solomon/DefaultSettings/Activation/ByHour/Percentage/Percentage", | |||
"/AppConfig/QueryServiceConfig/Solomon/DefaultSettings/Name/Name", | |||
"/AppConfig/QueryServiceConfig/Solomon/DefaultSettings/Value/Value", | |||
"/AppConfig/QueryServiceConfig/Solomon/DefaultSettings/Value/Value", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Во-первых, это копи-паста предыдущей строки.
ydb/core/config/ut/main.cpp
Outdated
"/AppConfig/QueryServiceConfig/Pq/ClusterMapping/Settings/Activation/ByHour/Hour/Hour", | ||
"/AppConfig/QueryServiceConfig/Pq/DefaultSettings/Activation/ByHour/Hour/Hour", | ||
"/AppConfig/QueryServiceConfig/Pq/DefaultSettings/Activation/ByHour/Percentage/Percentage", | ||
"/AppConfig/QueryServiceConfig/Pq/ClusterMapping/Settings/Activation/ByHour/Percentage/Percentage", | ||
"/AppConfig/QueryServiceConfig/Pq/DefaultSettings/Name/Name", | ||
"/AppConfig/QueryServiceConfig/Pq/ClusterMapping/Settings/Name/Name", | ||
"/AppConfig/QueryServiceConfig/Pq/DefaultSettings/Value/Value", | ||
"/AppConfig/QueryServiceConfig/Pq/ClusterMapping/Settings/Value/Value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Во-вторых, тест называется ForbidNewRequired
, а тут добавляются новый required поля.
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK - ok
Changelog entry
Added new external data source to ydb topics.
Example:
...
Changelog category
Description for reviewers
...