Skip to content

Added support sys view path type to Viewer backend #18898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Added support sys view path type to Viewer backend #18898

merged 1 commit into from
May 29, 2025

Conversation

n00bcracker
Copy link
Collaborator

@n00bcracker n00bcracker commented May 27, 2025 •
edited
Loading

This PR is one of series aimed to store sys view paths in SchemeShard.
To implement that system view path type was added and now we have to support it in Vewer backend acting like it's an ordinal table path.

@n00bcracker n00bcracker linked an issue May 27, 2025 that may be closed by this pull request
Support system view path type in Viewer #18895
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

⚪ 2025-05-27 10:58:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for dda1e0b has started.
⚪ 2025-05-27 10:59:06 UTC Artifacts will be uploaded here
⚪ 2025-05-27 11:02:00 UTC ya make is running...
🟡 2025-05-27 12:48:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30266 27572 0 6 2653 35

⚪ 2025-05-27 12:50:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-27 13:37:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 139 0 0 0 32

🟢 2025-05-27 13:37:33 UTC Build successful.
🟡 2025-05-27 13:37:54 UTC ydbd size 2.2 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: dda1e0b diff diff %
ydbd size 2 358 248 400 Bytes 2 359 590 984 Bytes +1.3 MiB +0.057%
ydbd stripped size 495 390 920 Bytes 495 620 776 Bytes +224.5 KiB +0.046%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

⚪ 2025-05-27 10:58:58 UTC Pre-commit check linux-x86_64-release-asan for dda1e0b has started.
⚪ 2025-05-27 10:59:09 UTC Artifacts will be uploaded here
⚪ 2025-05-27 11:02:07 UTC ya make is running...
🟡 2025-05-27 13:09:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15295 15115 0 76 82 22

⚪ 2025-05-27 13:10:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-27 13:39:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1391 (only retried tests) 1252 0 57 59 23

⚪ 2025-05-27 13:40:01 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-27 14:06:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1079 (only retried tests) 994 0 45 20 20

🟢 2025-05-27 14:06:30 UTC Build successful.
🔴 2025-05-27 14:07:00 UTC ydbd size 3.9 GiB changed* by +2.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: dda1e0b diff diff %
ydbd size 4 147 273 176 Bytes 4 149 968 872 Bytes +2.6 MiB +0.065%
ydbd stripped size 1 440 065 016 Bytes 1 440 745 944 Bytes +665.0 KiB +0.047%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

🟢 2025-05-27 11:00:51 UTC The validation of the Pull Request description is successful.

@n00bcracker n00bcracker marked this pull request as ready for review May 27, 2025 14:18
@n00bcracker n00bcracker requested a review from a team as a code owner May 27, 2025 14:18
@antonkovalenko antonkovalenko requested a review from adameat May 27, 2025 14:51
@n00bcracker n00bcracker force-pushed the viewer_sysview_pathtype_support branch from 823561c to eb4d567 Compare May 28, 2025 09:25
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

⚪ 2025-05-28 09:26:46 UTC Pre-commit check linux-x86_64-release-asan for 2acc862 has started.
⚪ 2025-05-28 09:26:56 UTC Artifacts will be uploaded here
⚪ 2025-05-28 09:29:49 UTC ya make is running...
🟡 2025-05-28 11:21:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15524 15243 0 164 94 23

⚪ 2025-05-28 11:22:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-28 12:05:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2295 (only retried tests) 2198 0 55 22 20

⚪ 2025-05-28 12:06:03 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-28 12:35:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1315 (only retried tests) 1226 0 49 19 21

🟢 2025-05-28 12:35:37 UTC Build successful.
🔴 2025-05-28 12:36:08 UTC ydbd size 3.9 GiB changed* by +6.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 2acc862 diff diff %
ydbd size 4 147 273 176 Bytes 4 154 171 696 Bytes +6.6 MiB +0.166%
ydbd stripped size 1 440 065 016 Bytes 1 441 982 904 Bytes +1.8 MiB +0.133%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

⚪ 2025-05-29 07:28:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2acc862 has started.
⚪ 2025-05-29 07:28:57 UTC Artifacts will be uploaded here
⚪ 2025-05-29 07:32:03 UTC ya make is running...
🟡 2025-05-29 08:52:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30501 27790 0 8 2655 48

⚪ 2025-05-29 08:55:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 09:31:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1080 (only retried tests) 1032 0 4 4 40

⚪ 2025-05-29 09:32:10 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-29 10:10:14 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1041 (only retried tests) 1006 0 1 0 34

🟢 2025-05-29 10:10:25 UTC Build successful.
🔴 2025-05-29 10:10:40 UTC ydbd size 2.2 GiB changed* by +3.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 2acc862 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 087 000 Bytes +3.7 MiB +0.163%
ydbd stripped size 495 390 920 Bytes 495 988 648 Bytes +583.7 KiB +0.121%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker force-pushed the viewer_sysview_pathtype_support branch from eb4d567 to 1ecdfec Compare May 29, 2025 10:23
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 12:22:07 UTC Pre-commit check linux-x86_64-release-asan for 4dd35b7 has started.
⚪ 2025-05-29 12:22:11 UTC Artifacts will be uploaded here
⚪ 2025-05-29 12:25:08 UTC ya make is running...
🟡 2025-05-29 14:01:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15532 15317 0 114 76 25

⚪ 2025-05-29 14:03:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 14:36:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1778 (only retried tests) 1666 0 69 23 20

⚪ 2025-05-29 14:37:04 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 15:10:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1536 (only retried tests) 1446 0 52 17 21

🟢 2025-05-29 15:10:38 UTC Build successful.
🔴 2025-05-29 15:11:12 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 4dd35b7 diff diff %
ydbd size 4 147 273 176 Bytes 4 154 917 368 Bytes +7.3 MiB +0.184%
ydbd stripped size 1 440 065 016 Bytes 1 442 218 008 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 12:22:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4dd35b7 has started.
⚪ 2025-05-29 12:22:22 UTC Artifacts will be uploaded here
⚪ 2025-05-29 12:25:22 UTC ya make is running...
🟡 2025-05-29 13:45:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30515 27818 0 3 2653 41

⚪ 2025-05-29 13:48:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-29 14:27:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
908 (only retried tests) 879 0 0 0 29

🟢 2025-05-29 14:27:25 UTC Build successful.
🔴 2025-05-29 14:27:44 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 4dd35b7 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 413 864 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 024 936 Bytes +619.2 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker merged commit b08e92f into ydb-platform:main May 29, 2025
13 of 15 checks passed
@n00bcracker n00bcracker deleted the viewer_sysview_pathtype_support branch May 29, 2025 15:21
@n00bcracker n00bcracker mentioned this pull request May 30, 2025
Open
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@n00bcracker
Added support sys view path type to Viewer backend (ydb-platform#18898)
59dd9ea
@n00bcracker n00bcracker mentioned this pull request Jun 20, 2025
Open
23 tasks
@n00bcracker n00bcracker mentioned this pull request Jul 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adameat adameat adameat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support system view path type in Viewer
2 participants
@n00bcracker @adameat