Skip to content

WaitInput/OutputTimes for Reads from CS #18727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented May 23, 2025

Two things added:

  1. WaitInputTime for task for reading with TKqpTableReader (it uses non standard binding to TaskRunner and should be integrated separately)
  2. WaitOutputTime for "CS reads" (ScanFetcher). Seems not to be very truthful yet, so is not visualized in SVG

@Hor911 Hor911 requested review from a team as code owners May 23, 2025 10:04
Copy link

github-actions bot commented May 23, 2025

🟢 2025-05-27 10:51:07 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented May 23, 2025

2025-05-23 10:07:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc40743 has started.
2025-05-23 10:07:41 UTC Artifacts will be uploaded here
2025-05-23 10:10:34 UTC ya make is running...
🔴 2025-05-23 11:36:34 UTC Too many tests failed, NOT going to retry
🔴 2025-05-23 11:49:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30351 22055 0 5410 2848 38

🟢 2025-05-23 11:52:08 UTC Build successful.
🟢 2025-05-23 11:52:39 UTC ydbd size 2.2 GiB changed* by +18.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 94d96d2 merge: dc40743 diff diff %
ydbd size 2 357 734 024 Bytes 2 357 752 640 Bytes +18.2 KiB +0.001%
ydbd stripped size 495 287 848 Bytes 495 291 496 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 23, 2025

2025-05-23 10:08:23 UTC Pre-commit check linux-x86_64-release-asan for dc40743 has started.
2025-05-23 10:08:34 UTC Artifacts will be uploaded here
2025-05-23 10:11:28 UTC ya make is running...
🟡 2025-05-23 11:48:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15410 15206 0 137 41 26

2025-05-23 11:50:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-23 12:23:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1407 (only retried tests) 1247 0 111 24 25

2025-05-23 12:24:19 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-23 12:57:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1324 (only retried tests) 1173 0 94 34 23

🟢 2025-05-23 12:58:06 UTC Build successful.
🟢 2025-05-23 12:58:41 UTC ydbd size 3.9 GiB changed* by +37.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 94d96d2 merge: dc40743 diff diff %
ydbd size 4 146 345 048 Bytes 4 146 382 888 Bytes +37.0 KiB +0.001%
ydbd stripped size 1 439 785 880 Bytes 1 439 800 408 Bytes +14.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 force-pushed the waits_on_cs_reads branch from 1e84900 to 7c2bff3 Compare May 24, 2025 22:09
Copy link

github-actions bot commented May 24, 2025

2025-05-24 22:13:11 UTC Pre-commit check linux-x86_64-release-asan for 6c7f1ec has started.
2025-05-24 22:13:21 UTC Artifacts will be uploaded here
2025-05-24 22:16:14 UTC ya make is running...
🟡 2025-05-24 23:53:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15404 15213 0 132 36 23

2025-05-24 23:55:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-25 00:27:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1305 (only retried tests) 1158 0 96 29 22

2025-05-25 00:27:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-25 00:57:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1124 (only retried tests) 985 0 91 27 21

🟢 2025-05-25 00:57:44 UTC Build successful.
🟢 2025-05-25 00:58:16 UTC ydbd size 3.9 GiB changed* by +33.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e727aaf merge: 6c7f1ec diff diff %
ydbd size 4 147 096 056 Bytes 4 147 129 808 Bytes +33.0 KiB +0.001%
ydbd stripped size 1 439 991 096 Bytes 1 440 001 528 Bytes +10.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 24, 2025

2025-05-24 22:13:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6c7f1ec has started.
2025-05-24 22:13:27 UTC Artifacts will be uploaded here
2025-05-24 22:16:30 UTC ya make is running...
🔴 2025-05-24 23:42:19 UTC Too many tests failed, NOT going to retry
🔴 2025-05-24 23:53:11 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30395 22089 0 5424 2837 45

🟢 2025-05-24 23:56:02 UTC Build successful.
🟢 2025-05-24 23:56:36 UTC ydbd size 2.2 GiB changed* by +18.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e727aaf merge: 6c7f1ec diff diff %
ydbd size 2 358 140 456 Bytes 2 358 159 000 Bytes +18.1 KiB +0.001%
ydbd stripped size 495 368 936 Bytes 495 372 520 Bytes +3.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 25, 2025

2025-05-25 18:25:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5f55aa8 has started.
2025-05-25 18:26:07 UTC Artifacts will be uploaded here
2025-05-25 18:29:09 UTC ya make is running...
🟡 2025-05-25 19:54:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30405 27711 0 2 2651 41

2025-05-25 19:56:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-25 20:32:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
679 (only retried tests) 639 0 0 2 38

🟢 2025-05-25 20:32:58 UTC Build successful.
🟢 2025-05-25 20:33:16 UTC ydbd size 2.2 GiB changed* by +17.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d617cc1 merge: 5f55aa8 diff diff %
ydbd size 2 358 248 400 Bytes 2 358 266 696 Bytes +17.9 KiB +0.001%
ydbd stripped size 495 390 920 Bytes 495 394 568 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 25, 2025

2025-05-25 18:26:11 UTC Pre-commit check linux-x86_64-release-asan for 5f55aa8 has started.
2025-05-25 18:26:22 UTC Artifacts will be uploaded here
2025-05-25 18:29:30 UTC ya make is running...
🟡 2025-05-25 20:13:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15425 15216 0 146 39 24

2025-05-25 20:15:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-25 20:45:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1267 (only retried tests) 1163 0 55 26 23

2025-05-25 20:46:13 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-25 21:13:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1128 (only retried tests) 1040 0 51 16 21

🟢 2025-05-25 21:13:47 UTC Build successful.
🟢 2025-05-25 21:14:19 UTC ydbd size 3.9 GiB changed* by +33.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d617cc1 merge: 5f55aa8 diff diff %
ydbd size 4 147 273 176 Bytes 4 147 307 000 Bytes +33.0 KiB +0.001%
ydbd stripped size 1 440 065 016 Bytes 1 440 075 256 Bytes +10.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 26, 2025

2025-05-26 07:23:42 UTC Pre-commit check linux-x86_64-release-asan for 2d4bd85 has started.
2025-05-26 07:23:53 UTC Artifacts will be uploaded here
2025-05-26 07:26:50 UTC ya make is running...
🟡 2025-05-26 08:59:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15317 15148 0 97 47 25

2025-05-26 09:01:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-26 09:29:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1355 (only retried tests) 1254 0 57 20 24

🟢 2025-05-26 09:31:49 UTC ydbd size 3.9 GiB changed* by +24.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d617cc1 merge: 2d4bd85 diff diff %
ydbd size 4 147 273 176 Bytes 4 147 298 632 Bytes +24.9 KiB +0.001%
ydbd stripped size 1 440 065 016 Bytes 1 440 072 248 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 26, 2025

2025-05-26 07:25:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2d4bd85 has started.
2025-05-26 07:25:57 UTC Artifacts will be uploaded here
2025-05-26 07:28:53 UTC ya make is running...
🟢 2025-05-26 08:53:14 UTC ydbd size 2.2 GiB changed* by +13.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d617cc1 merge: 2d4bd85 diff diff %
ydbd size 2 358 248 400 Bytes 2 358 261 960 Bytes +13.2 KiB +0.001%
ydbd stripped size 495 390 920 Bytes 495 393 480 Bytes +2.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 removed the request for review from a team May 26, 2025 11:04
@Hor911 Hor911 added the rebase-and-check Rebase PR with the current base branch and check label May 26, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 26, 2025
Copy link

github-actions bot commented May 26, 2025

2025-05-26 11:05:35 UTC Pre-commit check linux-x86_64-release-asan for 1c7dec3 has started.
2025-05-26 11:05:46 UTC Artifacts will be uploaded here
2025-05-26 11:08:38 UTC ya make is running...
🟡 2025-05-26 12:44:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15333 15216 0 66 26 25

2025-05-26 12:45:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-26 13:13:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
761 (only retried tests) 673 0 48 18 22

2025-05-26 13:13:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-26 13:41:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1085 (only retried tests) 965 0 66 33 21

🟢 2025-05-26 13:42:12 UTC Build successful.
🟡 2025-05-26 13:42:43 UTC ydbd size 3.9 GiB changed* by +406.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 1c7dec3 diff diff %
ydbd size 4 147 273 176 Bytes 4 147 689 824 Bytes +406.9 KiB +0.010%
ydbd stripped size 1 440 065 016 Bytes 1 440 201 880 Bytes +133.7 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 26, 2025

2025-05-26 11:05:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1c7dec3 has started.
2025-05-26 11:05:46 UTC Artifacts will be uploaded here
2025-05-26 11:08:46 UTC ya make is running...
🟡 2025-05-26 12:33:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30309 27603 0 2 2663 41

2025-05-26 12:36:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-26 13:06:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
707 (only retried tests) 673 0 0 0 34

🟢 2025-05-26 13:06:57 UTC Build successful.
🟡 2025-05-26 13:07:17 UTC ydbd size 2.2 GiB changed* by +234.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 1c7dec3 diff diff %
ydbd size 2 358 248 400 Bytes 2 358 488 480 Bytes +234.5 KiB +0.010%
ydbd stripped size 495 390 920 Bytes 495 442 472 Bytes +50.3 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 merged commit 9d13274 into ydb-platform:main May 27, 2025
18 of 21 checks passed
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants