Skip to content

How to write compat tests #18499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 19, 2025
Merged

How to write compat tests #18499

merged 21 commits into from
May 19, 2025
+45 −28

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented May 19, 2025 •
edited
Loading

Added "how to write test"

@maximyurchuk maximyurchuk marked this pull request as ready for review May 19, 2025 13:37
@maximyurchuk maximyurchuk requested a review from galnat May 19, 2025 13:38
@maximyurchuk maximyurchuk changed the title Docs fixt How to write compat tests May 19, 2025
naspirato
naspirato previously approved these changes May 19, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

⚪ 2025-05-19 13:43:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for d80f751 has started.
⚪ 2025-05-19 13:43:25 UTC Artifacts will be uploaded here
⚪ 2025-05-19 13:45:49 UTC ya make is running...
🟢 2025-05-19 13:47:14 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 9 0 0 0 0

🟢 2025-05-19 13:47:20 UTC Build successful.
🟢 2025-05-19 13:47:29 UTC ydbd size 2.2 GiB changed* by -103.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b7d9010 merge: d80f751 diff diff %
ydbd size 2 354 365 360 Bytes 2 354 258 944 Bytes -103.9 KiB -0.005%
ydbd stripped size 494 718 792 Bytes 494 676 936 Bytes -40.9 KiB -0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

🟢 2025-05-19 13:44:02 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

⚪ 2025-05-19 13:43:50 UTC Pre-commit check linux-x86_64-release-asan for d80f751 has started.
⚪ 2025-05-19 13:44:02 UTC Artifacts will be uploaded here
⚪ 2025-05-19 13:46:26 UTC ya make is running...
🟢 2025-05-19 13:48:13 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
7 7 0 0 0 0

🟢 2025-05-19 13:48:19 UTC Build successful.
🟢 2025-05-19 13:48:32 UTC ydbd size 3.9 GiB changed* by -164.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b7d9010 merge: d80f751 diff diff %
ydbd size 4 141 801 824 Bytes 4 141 633 016 Bytes -164.9 KiB -0.004%
ydbd stripped size 1 437 655 000 Bytes 1 437 597 592 Bytes -56.1 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

galnat
galnat reviewed May 19, 2025
View reviewed changes
ydb/tests/compatibility/README.md Outdated
@@ -2,13 +2,20 @@

Одна из мажорных проблем в новых стабильных ветках состоит в том, что в рамках апгрейда YDB со старой версии возникают несовмстимости между новой и старой версией. Данные тесты призваны протестировать этот сценарий. Механика тестов следующая: тесты скачивают YDB последней стабильной версии.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай поменяем на "Тесты совместимости позволяют обнаруживать ошибки, которые возникают при апгрейде и даунгрейде YDB Server. ".

Механику тестов я бы вынесла отдельным абзацом. А то непонятно, к чему тут одно как-будто незаконченное предложение.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И тут опечатка в слове несовместимость. Прогони через ai текст на предмет орфографических ошибок, пожалуйста.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Прогони через ai текст на предмет орфографических ошибок, пожалуйста." -- вот я если често, думал копайлот с гитхаба мне все напишет, но он проигнорировал похоже этот файл:(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"YDB Server" -- я если честно, предпочитаю просто YDB, server как будто лишняя приписка, предлагаю не надо

ydb/tests/compatibility/README.md Outdated
Для упрощения написания тестов было сделано несколько тестовых фикстур, которые предоставляют типовые сценарии тестирования. Все фикстуры поднимают кластер `MIRROR_3_DC` и предоставляют его для тестирования.
## Как написать тест

1. Выбрать подходящую фикстуру
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и ссылка на блок с фикстурами.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

⚪ 2025-05-19 14:35:16 UTC Pre-commit check linux-x86_64-release-asan for 08c4a13 has started.
⚪ 2025-05-19 14:35:20 UTC Artifacts will be uploaded here
⚪ 2025-05-19 14:37:39 UTC ya make is running...
🟢 2025-05-19 14:39:27 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
7 7 0 0 0 0

🟢 2025-05-19 14:39:36 UTC Build successful.
🟢 2025-05-19 14:39:50 UTC ydbd size 3.9 GiB changed* by -164.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b2e4183 merge: 08c4a13 diff diff %
ydbd size 4 141 801 824 Bytes 4 141 633 272 Bytes -164.6 KiB -0.004%
ydbd stripped size 1 437 655 000 Bytes 1 437 597 720 Bytes -55.9 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk enabled auto-merge (squash) May 19, 2025 14:48
@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

⚪ 2025-05-19 15:10:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 08c4a13 has started.
⚪ 2025-05-19 15:11:16 UTC Artifacts will be uploaded here
⚪ 2025-05-19 15:14:09 UTC ya make is running...
🟢 2025-05-19 15:15:30 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 9 0 0 0 0

🟢 2025-05-19 15:15:36 UTC Build successful.
🟢 2025-05-19 15:15:45 UTC ydbd size 2.2 GiB changed* by -103.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b2e4183 merge: 08c4a13 diff diff %
ydbd size 2 354 365 360 Bytes 2 354 259 296 Bytes -103.6 KiB -0.005%
ydbd stripped size 494 718 792 Bytes 494 676 936 Bytes -40.9 KiB -0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit 6f047c5 into ydb-platform:main May 19, 2025
11 checks passed
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 20, 2025
@maximyurchuk @nshestakov
How to write compat tests (ydb-platform#18499)
c73ccc9
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@maximyurchuk
How to write compat tests (ydb-platform#18499)
53a679d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galnat galnat galnat approved these changes

@naspirato naspirato naspirato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximyurchuk @naspirato @galnat