-
Notifications
You must be signed in to change notification settings - Fork 20
59 Replace THashSet to std::unordered_set #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR для #59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ты не убрала сам файл с THashSet и его тестами в util. Их надо убрать
f22ed95
to
f80de66
Compare
f80de66
to
dfb5a66
Compare
@GitSparTV исправила конфликты и ошибку сборки |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привет. Ура! Конфликты решены. Критичного ничего нет, но коммитик один понадобится
library/cpp/cache/cache.h
Outdated
@@ -332,7 +336,9 @@ class TLWList { | |||
TValue Value; | |||
TWeight Weight; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
строчка пришла лишняя
#include <util/string/join.h> | ||
#include <util/string/subst.h> | ||
//#include <util/generic/hash_set.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Остался комментарий
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitSparTV готово.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Отлично!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В целом никаких проблем нет, замечания по мелочи. Поправь сегодня, пожалуйста
No description provided.