Skip to content

59 Replace THashSet to std::unordered_set #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

SvRgK11010
Copy link
Contributor

No description provided.

@SvRgK11010 SvRgK11010 linked an issue Mar 14, 2024 that may be closed by this pull request
@SvRgK11010 SvRgK11010 requested a review from GitSparTV March 14, 2024 10:07
@GitSparTV
Copy link

PR для #59

Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ты не убрала сам файл с THashSet и его тестами в util. Их надо убрать

@SvRgK11010 SvRgK11010 force-pushed the 59-replace-thashset-to-stdunordered_set branch from f22ed95 to f80de66 Compare April 4, 2024 09:40
@SvRgK11010 SvRgK11010 force-pushed the 59-replace-thashset-to-stdunordered_set branch from f80de66 to dfb5a66 Compare April 6, 2024 14:33
@SvRgK11010
Copy link
Contributor Author

@GitSparTV исправила конфликты и ошибку сборки

Copy link

@GitSparTV GitSparTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет. Ура! Конфликты решены. Критичного ничего нет, но коммитик один понадобится

@@ -332,7 +336,9 @@ class TLWList {
TValue Value;
TWeight Weight;


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

строчка пришла лишняя

#include <util/string/join.h>
#include <util/string/subst.h>
//#include <util/generic/hash_set.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Остался комментарий

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitSparTV готово.

Copy link

@GitSparTV GitSparTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отлично!

Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом никаких проблем нет, замечания по мелочи. Поправь сегодня, пожалуйста

@Gazizonoki Gazizonoki merged commit 93a6aa8 into main Apr 9, 2024
@Gazizonoki Gazizonoki deleted the 59-replace-thashset-to-stdunordered_set branch April 9, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace THashSet to std::unordered_set
3 participants