Skip to content

TDeque to std::deque #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2024
Merged

TDeque to std::deque #133

merged 3 commits into from
Apr 10, 2024

Conversation

Lomzovat
Copy link
Contributor

@Lomzovat Lomzovat commented Apr 8, 2024

No description provided.

Copy link

@GitSparTV GitSparTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Много времени прошло, но у нас были другие задачи.

Кроме прямой замены нужно посмотреть остался ли смысл от кода, где использовались деки. Комментирование – это прошлый век, у нас есть Git :-)
Приберись в классе и тестах

@@ -5,6 +5,7 @@
#include <util/generic/deque.h>
#include <util/generic/hash.h>


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пробел лишний

@@ -8,7 +8,7 @@
#include <memory>
#include <initializer_list>

template <class T, class A>
/*template <class T, class A>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если кроме деки тут ничего не осталось, нужно удалить файл

@@ -27,7 +27,7 @@ class TDequeTest: public TTestBase {
UNIT_TEST_SUITE_REGISTRATION(TDequeTest);

void TDequeTest::TestConstructorsAndAssignments() {
using container = TDeque<int>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тесты для STL деки не нужны

@GitSparTV
Copy link

Fixes #58

@Gazizonoki Gazizonoki linked an issue Apr 8, 2024 that may be closed by this pull request
@Gazizonoki Gazizonoki requested a review from GitSparTV April 9, 2024 13:21
Copy link

@GitSparTV GitSparTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

К сожалению, пока не всё. Появились новые файлы, которые надо именно удалить

@@ -1,9 +1,9 @@
from libcpp.deque cimport deque
/*from libcpp.deque cimport deque

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это питоновский экспортер. Деки больше нет. От файла можно избавиться

@Gazizonoki Gazizonoki merged commit 554b9fc into main Apr 10, 2024
@Gazizonoki Gazizonoki deleted the 58TDeque branch April 10, 2024 13:52
Jlucblu pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace TDeque to std::deque
3 participants