-
Notifications
You must be signed in to change notification settings - Fork 20
TDeque to std::deque #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDeque to std::deque #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привет! Много времени прошло, но у нас были другие задачи.
Кроме прямой замены нужно посмотреть остался ли смысл от кода, где использовались деки. Комментирование – это прошлый век, у нас есть Git :-)
Приберись в классе и тестах
library/cpp/http/io/compression.h
Outdated
@@ -5,6 +5,7 @@ | |||
#include <util/generic/deque.h> | |||
#include <util/generic/hash.h> | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Пробел лишний
util/generic/deque.h
Outdated
@@ -8,7 +8,7 @@ | |||
#include <memory> | |||
#include <initializer_list> | |||
|
|||
template <class T, class A> | |||
/*template <class T, class A> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если кроме деки тут ничего не осталось, нужно удалить файл
@@ -27,7 +27,7 @@ class TDequeTest: public TTestBase { | |||
UNIT_TEST_SUITE_REGISTRATION(TDequeTest); | |||
|
|||
void TDequeTest::TestConstructorsAndAssignments() { | |||
using container = TDeque<int>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тесты для STL деки не нужны
Fixes #58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
К сожалению, пока не всё. Появились новые файлы, которые надо именно удалить
util/generic/deque.pxd
Outdated
@@ -1,9 +1,9 @@ | |||
from libcpp.deque cimport deque | |||
/*from libcpp.deque cimport deque |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это питоновский экспортер. Деки больше нет. От файла можно избавиться
No description provided.