Issue #91 remove googletest from contrib #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asic_string_view (#91)
Before replacement TString to std::string, the first one had operator bool, checking a string for emptiness
There's no guarantees that std::string::size_type will be always std::size_t
Old TMaybe had the second template parameter aka Policy, determining behavior of the value direct access if the value doesn't exist (throwing exception or doing something else). We don't need this template type parameter here since we always check optional for existence
* Rearrange std::string and std::string_view includes so that they are located in the group of the standard includes. * Fix some operator ""s and ""sv, which demanded using directives such as std::string_literals and std::string_view_literals. * Replace some explicit std::string and std::string_view constructors to operator ""s and ""sv.
It was used to include the header 'gtest_prod.h' from contrib/restricted/googletest/include. With using imported targets from GTest there's no need for that, because it's already included through googletest's header 'gtest.h'.
'cpp-testing-common' library uses 'GetArcadiaSourcePath' function that's declared in 'scripts/c_templates/svnversion.h'. We need to use cmake function 'vcs_info' that runs the python script generating necessary C-file, and links that file with the library.
Since there's the special library for that purpose (library/cpp/svnversion), it's better to use it, and not some scripts folder using for file generation. At least 'library/cpp/getopt' is doing so.
This macros gets a path to the current file and strips the prefix that is either ARCADIA_ROOT or ARCADIA_BUILD_ROOT, i.e. the top source and binary directory. So the final path turns out to be relative. But neither ARCADIA_ROOT or ARCADIA_BUILD_ROOT are defined. Probably, they were defined using ya make building system, but now it's not the case. The current behavior breaks some unit tests, so there's the solution: using CMake top source and build path variables we can define helper macro definitions, which will be substituted instead of ARCADIA_[BUILD]_ROOT if those macros are not defined.
Gazizonoki
approved these changes
Apr 1, 2024
Jlucblu
pushed a commit
that referenced
this pull request
Apr 4, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 5, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 24, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 24, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 24, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Jlucblu
pushed a commit
that referenced
this pull request
Apr 25, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Gazizonoki
added a commit
that referenced
this pull request
May 20, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Gazizonoki
added a commit
that referenced
this pull request
May 20, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Gazizonoki
added a commit
that referenced
this pull request
May 20, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Gazizonoki
added a commit
that referenced
this pull request
May 20, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Gazizonoki
added a commit
that referenced
this pull request
May 20, 2024
--------- Co-authored-by: Bulat <[email protected]> Co-authored-by: Bulat Gayazov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #91
Добавил также
CMakeListsфайлы для юнит тестов внутриlibrary/cpp/testing, чтобы проверить, что всё работает. Это временное решение, т.к. пока мне не ясно как у нас будут включаться тесты: через какой-нибудь ключENABLE_TESTING, который черезif-ы будет всё включать (enable_testing()и остальное), или иным образом. По той же причинеfind_package(GTest)пока объявлен какREQUIRED, в идеале он должен искаться только, если включена поддержка тестирования.Впрочем, задача была, чтобы библиотека собиралась, и сейчас она собирается.
Из интересного:
ya makeнекоторые вещи перестали работать корректно сейчас. Например, предполагаю, что раньшеya makeсамостоятельно устанавливал макро определенияARCADIA_ROOTиARCADIA_BUILD_ROOT, как пути до верхнего уровня source- и build-файлов. В библиотеке так же был определён макрос__SOURCE_FILE__(его реализация вutil/system/src_root.h), который брал текущий путь до файла и обрезал у него префикс, если мог, так, чтобы получился путь, относительный верхнего уровня source- или build-файлов, в зависимости, где текущий файл находился. Из-за того, что первые макро определения отсутствовали, макрос ничего не обрезал, и это ломало остальные функции. Я исправил это, как мог, не трогаяARCADIA_ROOTиARCADIA_BUILD_ROOT, если они определены, но на случай, если нет, вместо них подставляются пути изCMAKE_SOURCE_DIRиCMAKE_BINARY_DIR. Это починило падающие тесты.gdb(library/cpp/testing/common/ut/env_ut.cpp, Runtime, GdbPath). С ним пока не получилось разобраться.