Implemented dump of novelty points from archive into JSON for better compatibility with other tools. #4
Conversation
…compatibility with other tools.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 39.31% 39.62% +0.31%
==========================================
Files 9 9
Lines 702 699 -3
==========================================
+ Hits 276 277 +1
+ Misses 402 400 -2
+ Partials 24 22 -2
Continue to review full report at Codecov.
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
| // decode and check | ||
| var novelItems []*NoveltyItem | ||
| err = json.Unmarshal(buf.Bytes(), &novelItems) |
There was a problem hiding this comment.
SA4006: this value of err is never used
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| // decode and check | ||
| var novelItems []*NoveltyItem | ||
| err = json.Unmarshal(buf.Bytes(), &novelItems) |
There was a problem hiding this comment.
ineffassign: ineffectual assignment to err
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| // decode and check | ||
| var novelItems []*NoveltyItem | ||
| err = json.Unmarshal(buf.Bytes(), &novelItems) |
There was a problem hiding this comment.
SA4006: this value of err is never used
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| // decode and check | ||
| var novelItems []*NoveltyItem | ||
| err = json.Unmarshal(buf.Bytes(), &novelItems) |
There was a problem hiding this comment.
ineffassign: ineffectual assignment to err
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
No description provided.