Skip to content

Conversation

markisha64
Copy link
Contributor

PR Details

generated go types and fields aren't properly capitalized when xsd uses _ or - ending up in names like Dateexpiration instead of DateExpiration etc.

Description

capitalizes first letter after every split

Motivation and Context

will make generated go code more readable

How Has This Been Tested

tested on xsd using - and _ in field names

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Marko Grizelj <[email protected]>
@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2025
xuri added a commit to xuri/xsd that referenced this pull request Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.58%. Comparing base (8c60951) to head (8a12adc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   81.63%   81.58%   -0.06%     
==========================================
  Files          36       36              
  Lines        1840     1835       -5     
==========================================
- Hits         1502     1497       -5     
  Misses        246      246              
  Partials       92       92              
Flag Coverage Δ
unittests 81.58% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit d9d0ba0 into xuri:master Jul 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants