Skip to content

Revert memory regression #617 (and revert "remove fs-extra") #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devinrhode2 wants to merge 4 commits into from
Closed

Revert memory regression #617 (and revert "remove fs-extra") #619

devinrhode2 wants to merge 4 commits into from

Conversation

@devinrhode2
Copy link
Contributor

@devinrhode2 devinrhode2 commented Oct 15, 2021

taking the truly brain-dead approach and also reverting the "remove fs-extra" commit, fingers crossed build passes

I'm not concerned with seeing this PR merged

  • primarily, I am just curious if the build will pass
  • secondarily, others can see this PR, if they are suffering from memory regression, this branch may help them

@devinrhode2 devinrhode2 mentioned this pull request Oct 15, 2021
Closed
@devinrhode2
Revert "Simplify lintFiles (xojs#583)"
dcb76f3 
This reverts commit e2e715d.
+add in "is-path-inside" dep
+remove unused/moot dep "path-exists"
@devinrhode2 devinrhode2 force-pushed the revert-fs-extra-and-fisker-regression-changes branch from fc8950d to dcb76f3 Compare October 15, 2021 18:57
@devinrhode2
Copy link
Contributor Author

devinrhode2 commented Nov 2, 2021

I'm not sure how much better memory usage is, as I'm always running XO with 16gb "xo": "/usr/bin/time node --max-old-space-size=16384 --stack-trace-limit=25 ./node_modules/.bin/xo",, but the main regression was solved (see original issue)

@devinrhode2 devinrhode2 closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@devinrhode2