Skip to content

Conversation

@dflupu
Copy link
Contributor

@dflupu dflupu commented Jan 29, 2019

Fixes #143

@dflupu dflupu force-pushed the add-webpack-option branch from aa000ab to f693cb8 Compare January 29, 2019 11:42
@sindresorhus sindresorhus force-pushed the master branch 2 times, most recently from 9bbe1bf to 2ab0a69 Compare May 25, 2019 08:31
@sindresorhus sindresorhus changed the title add webpack resolver option Add webpack option Feb 13, 2020
@sindresorhus
Copy link
Member

Sorry for the super slow review. I'm finally getting through all my PRs now.

@dflupu dflupu force-pushed the add-webpack-option branch 2 times, most recently from bad4b2b to f33a474 Compare February 13, 2020 17:26
@dflupu dflupu requested a review from sindresorhus February 13, 2020 19:51
@sindresorhus
Copy link
Member

You're testing that the config is correctly handled, but I think this needs an integration test too that ensures it actually works in practice in a Webpack project.

@dflupu
Copy link
Contributor Author

dflupu commented Mar 8, 2020

You're testing that the config is correctly handled, but I think this needs an integration test too that ensures it actually works in practice in a Webpack project.

I'm not sure how that could be done without actually adding Webpack as a dev dependency.

@sindresorhus
Copy link
Member

I'm not sure how that could be done without actually adding Webpack as a dev dependency.

We can add Webpack as a dev dependency.

@dflupu dflupu force-pushed the add-webpack-option branch from 616d588 to 615b352 Compare March 9, 2020 17:11
@sindresorhus sindresorhus merged commit f656ee3 into xojs:master Mar 11, 2020
@sindresorhus
Copy link
Member

Looks good to me now. Thanks for working on it :)

@dflupu
Copy link
Contributor Author

dflupu commented Mar 11, 2020

Thanks for the feedback on this! Felt like I've learned a few things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring towards webpack

2 participants