-
-
Notifications
You must be signed in to change notification settings - Fork 301
Add webpack option
#375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webpack option
#375
Conversation
aa000ab to
f693cb8
Compare
9bbe1bf to
2ab0a69
Compare
|
Sorry for the super slow review. I'm finally getting through all my PRs now. |
bad4b2b to
f33a474
Compare
|
You're testing that the config is correctly handled, but I think this needs an integration test too that ensures it actually works in practice in a Webpack project. |
I'm not sure how that could be done without actually adding Webpack as a dev dependency. |
We can add Webpack as a dev dependency. |
616d588 to
615b352
Compare
|
Looks good to me now. Thanks for working on it :) |
|
Thanks for the feedback on this! Felt like I've learned a few things. |
Fixes #143