Remove deprecated --compact CLI flag
#293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There's also a test using this option in |
Member
|
And can you update the PR title to be more specific about what's being fixed. |
Contributor
Author
|
Will do! |
wuweiweiwu
changed the title
sindresorhus
changed the title
--compact CLI flag
wuweiweiwu
commented
Feb 13, 2018
test/main.js
Outdated
| process.chdir(__dirname); | ||
|
|
||
| const main = (args, opts) => execa(path.join(__dirname, '../main.js'), args, opts); | ||
| const main = (args, opts) => |
Contributor
Author
There was a problem hiding this comment.
Oops. My prettier accidentally prettified this line. I can remove if needed
| } catch (err) { | ||
| t.true(err.stdout.indexOf('Error - ') !== -1); | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
Sorry, I misread this code. It should not be removed. It's not using the compact option.
test/main.js
Outdated
|
|
||
| const main = (args, opts) => execa(path.join(__dirname, '../main.js'), args, opts); | ||
| const main = (args, opts) => | ||
| execa(path.join(__dirname, '../main.js'), args, opts); |
Member
There was a problem hiding this comment.
Don't do unrelated changes.
Member
|
Great, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#289