Overrides not working when calling xo with absolute paths

[olavim]

I have this in my package.json:

"xo": {
  "extends": "xo-react",
  "parser": "babel-eslint",
  "plugins": ["react"],
  "envs": ["node", "browser"],
  "rules": {
    "react/forbid-component-props": 0,
    "react/jsx-closing-bracket-location": ["error", "tag-aligned"]
  },
  "overrides": [{
    "files": "src/client/components/*.js",
    "rules": {
      "unicorn/filename-case": [
        "error", {"case": "pascalCase"}
      ]
    }
  }, {
    "files": "src/client/containers/*.js",
    "rules": {
      "unicorn/filename-case": [
        "error",
        {"case": "pascalCase"}
      ]
    }
  }]
}

And I have the file src/client/components/ExtendedReferenceManyField.js

Now, if I call

$ xo src/client/components/ExtendedReferenceManyField.js

it finishes without errors. However, calling:

$ xo /home/user/dev/project/src/client/components/ExtendedReferenceManyField.js

will output:

  src/client/components/ExtendedReferenceManyField.js:1:1
  ✖  1:1  Filename is not in kebab case. Rename it to extended-reference-many-field.js.  unicorn/filename-case

  1 error

I stumbled on this while using lint-staged in my project.

---

xo version: 0.18.2
Node version: 6.10.1
OS: Linux Mint 18 Cinnamon 64-bit

futpib earned $60.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[timdeschryver]

could you try $ xo ./src/client/components/ExtendedReferenceManyField.js please?

[olavim]

@tdeschryver No error. I also tried changing the config to:

"xo": {
  "extends": "xo-react",
  "parser": "babel-eslint",
  "plugins": ["react"],
  "envs": ["node", "browser"],
  "rules": {
    "react/forbid-component-props": 0,
    "react/jsx-closing-bracket-location": ["error", "tag-aligned"]
  },
  "overrides": [{
    "files": "./src/client/components/*.js",
    "rules": {
      "unicorn/filename-case": [
        "error", {"case": "pascalCase"}
      ]
    }
  }, {
    "files": "./src/client/containers/*.js",
    "rules": {
      "unicorn/filename-case": [
        "error",
        {"case": "pascalCase"}
      ]
    }
  }]
}

and then calling

$ xo /home/user/dev/project/src/client/components/ExtendedReferenceManyField.js

but I had the same results (error).

[timdeschryver]

I've played around with this and my guess is this isn't xo related, since the results were the same when running eslint.

However its strange that the path must match the path in the config(?)
For example: if package.json is configured as ./src/client/components/*.js and xo src/client/components/ExtendedReferenceManyField.js has run, you will have an error suggesting the change to kebab-case but if you run xo ./src/client/components/ExtendedReferenceManyField.js the error disappears.

Also if you run xo ./src/client/components/extendedReferenceManyField.js (lowercase e), the error Filename is not in pascal case. Rename it to ExtendedReferenceManyField.js. is being shown.

[olavim]

@tdeschryver In your last example it works correctly, though.

[timdeschryver]

@tilastokeskus I found it weird because the file is in pascal case (ExtendedReferenceManyField.js), but in the command the file was written in camel case (extendedReferenceManyField.js).

[olavim]

@tdeschryver oh, you mean that it finds it even though it doesn't exist?

[timdeschryver]

@tilastokeskus it does exists but its written differently, camel case vs pascal case.

[zanona]

I believe I have fallen into the same issue when using lint-staged (http://npmjs.com/package/lint-staged) where it may be the case it sends absolute paths since my overrides config has no effect at all.

This Fails

{
  "lint-staged": {
    "*.js": [
      "xo --fix",
      "git add"
    ]
  },
  "xo": {
    "semicolon": false,
    "overrides": [
      {
        "files": "packages/shop-app/**",
        "envs": [
          "node",
          "browser"
        ]
      }
    ]
}

$ lint-staged
✔ Running tasks for package.json
❯ Running tasks for *.js
   ✖ xo --fix
     → ✖   24:4   postMessage is not defined.
     git add
✖ xo --fix found some errors. Please fix them and try committing again.

This Works

{
  "lint-staged": {
    "*.js": [
      "xo --fix",
      "git add"
    ]
  },
  "xo": {
    "semicolon": false,
    "overrides": [
      {
        "files": "/Users/zanona/Developer/my-app/packages/shop-app/**",
        "envs": [
          "node",
          "browser"
        ]
      }
    ]
}

$ lint-staged
✔ Running tasks for package.json
✔ Running tasks for *.js

[IssueHuntBot]

@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt