Library Querying#41
Open
Exterminate5573 wants to merge 3 commits into
Open
Conversation
imLinguin
reviewed
Jun 16, 2026
imLinguin
requested changes
Jun 16, 2026
| return; | ||
| }; | ||
|
|
||
| let token = user::get_token("scope=service::user.auth.xboxlive.com::MBI_SSL&api-version=2.0".to_string()).unwrap(); |
Member
There was a problem hiding this comment.
The new token may need to be obtained here. Those tokens are pretty short-lived.
You can band-aid a full exchange_user_token here as well. Or if you want to, look into doing proper utils towards caching tokens and refreshing them only as needed
Author
There was a problem hiding this comment.
I dont think its worth band-aiding it all together, working on a proper caching system would make more sense
|
|
||
| let user_token: Token = match user_token { | ||
| ExchangeUserTokenOutcome::Fault(_) => { | ||
| eprintln!("Failed to get exchange MS token"); |
Member
There was a problem hiding this comment.
For those eprintln, I think we should migrate to log::error instead
Member
|
I also hit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a library command, currently only outputs raw json