Fix edge case where hops can extend past frequency range.#16
Open
xloem wants to merge 1 commit intoxmikos:masterfrom
Open
Fix edge case where hops can extend past frequency range.#16xloem wants to merge 1 commit intoxmikos:masterfrom
xloem wants to merge 1 commit intoxmikos:masterfrom
Conversation
ceil()ing the count of hops can cause a weird hop count to be rounded up, which can cause the maximum center frequency to exceed the range. If the range was the device range, this will then cause the last hop to raise an error in the driver, crashing the program. This fix prevents this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ceil()ing the count of hops can cause an abnormal hop count to be rounded up, which can cause the maximum center frequency to exceed the range.
If the range was the device range, this will then cause the last hop to raise an error in the driver, crashing the program.
This fix prevents this.