Small fix for supporting neon for dnn in Windows ARM64 #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuanzhu
changed the title
jmvalin
reviewed
Jul 4, 2025
| @@ -402,11 +402,17 @@ static inline void cgemv8x4(float *_out, const opus_int8 *w, const float *scale, | |||
| for (;j<cols-4;j+=8) | |||
| { | |||
| int8x16_t vw0, vw1, vw2, vw3, vx0, vx1; | |||
| #if defined(_MSC_VER) && defined(_M_ARM64) | |||
| vx0 = vreinterpretq_s8_s32(vld1q_dup_s32((int*)(void*)&x[j])); | |||
There was a problem hiding this comment.
Any reason for making the use of vreinterpretq_s8_s32() conditional to Windows (as opposed to all the time)?
There was a problem hiding this comment.
Yes, it should use vreinterpretq_s8_s32 all the time no matter what platform it is, I didn't notice that vreinterpretq_s8_s32 was already defined in <arm_neon.h>. I thought it was only in <arm64_neon.h>. Thanks for the reminder. I have modified the code accordingly, please help review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support neon for windows arm64 with MSVC, I add small fix here, please help review.