Skip to content

The sample EOL DB for homebrew testing is outdated #568

@stefanb

Description

@stefanb

👋 Hey, Homebrew maintainer here.

There is a special case for homebrew test built into xeol:

xeol/xeol/db/curator.go

Lines 201 to 221 in fec1277

isBrewTest := os.Getenv("HOMEBREW_GITHUB_ACTIONS")
if isBrewTest == "1" {
sampleEntry := ListingEntry{
Built: time.Now(),
Version: 1,
Checksum: "sha256:8c3188056b129e55272b8d6c25cb9e27de59ec02b23c1a4c0e98f17d22333a31",
URL: &url.URL{
Scheme: "https",
Host: "s3.us-east-1.amazonaws.com",
Path: "/data.xeol.io/xeol/databases/sample.tar.gz",
},
}
sampleMeta := Metadata{
Built: time.Now(),
Version: 1,
Checksum: "sha256:8c3188056b129e55272b8d6c25cb9e27de59ec02b23c1a4c0e98f17d22333a31",
}
log.Infof("homebrew sample url: %s", sampleEntry)
return true, &sampleMeta, &sampleEntry, nil
}

Instead of the real database it is referencing an outdated one, causing a test failure with error

db could not be loaded: the eol database was built 17 weeks ago (max allowed age is 12 weeks)

Please either

  • remove this exception to let homebrew use the real (current, EDIT: possibly too big) database or
  • regularly update the sample database on the given URL or
  • adjust also the database age check for homebrew

The first option would provide most realistic check, but the real DB may be too big for the tests (see #504).

Ref:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions