Make pgroll latest schema ignore migrations for which no version schema exists
#916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage is failing because this is stacked on #914. When rebased it should show increased coverage of the |
andrew-farries
force-pushed
the
fix-pgroll-latest-schema-with-inferred-migs
branch
from
365c1f3 to
fc522e4
Compare
kvch
approved these changes
Jun 17, 2025
Base automatically changed from
remove-param-from-previous-migration-function
to
main
June 17, 2025 15:05
Add a new `find_version_schema` function to `init.sql` that retrieves version schema names schema based on a specified depth. Define the `previous_version` and `latest_version` in terms of this new function.
Remove redundant `includeInferred` parameter from `State.PreviousVersion` method calls.
Ensure that an inferred migration name without a version schema is not returned when calling `LatestVersionRemote`.
Move the latest and previous version and migration functions into their own file in the `pkg/state` package.
Ensure that the: * `LatestMigration` and `PreviousMigration` methods * `LatestVersion` and `PreviousVersion` methods work correctly in various scenarios.
andrew-farries
force-pushed
the
fix-pgroll-latest-schema-with-inferred-migs
branch
from
fc522e4 to
c51b6a9
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
divyenduz
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem described in #915 where
pgroll latest schemawill return version schema names for which no version schema exists in the database, such as forinferredmigrations.pgroll latest schemaBefore this PR the output would be incorrect:
The most recent migration (inferred from the
CREATE TABLE) did not create a version schema - the most recent schema version is stillpublic_01_create_tables.This PR corrects the behaviour of
pgroll latest schemato consider only migrations for which a version schema exists. So the output is:as expected.
Fixes #915
Related to #872