Skip to content

Conversation

andrew-farries
Copy link
Collaborator

WithNoVersionSchemaForRawSQL was a Xata specific option that was never exposed to users of the CLI. If we need it in future, we can reintroduce it but there is no need evidence of a need for it at the moment.

This change simplifies the code and removes the unnecessary complexity of handling raw SQL migrations differently in various places.

This was a Xata specific option that was never exposed to users of the
CLI. If we need it in future, we can reintroduce it but there is no need
for it at the moment.

This change simplifies the code and removes the unnecessary complexity
of handling raw SQL migrations differently in various places.
@github-actions github-actions bot temporarily deployed to Docs Preview June 13, 2025 14:15 Inactive
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/pkg/migrations 74.21% (-0.05%) 👎
github.com/xataio/pgroll/pkg/roll 79.75% (-0.19%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/pkg/migrations/migrations.go 94.12% (-1.12%) 17 (-4) 16 (-4) 1 👎
github.com/xataio/pgroll/pkg/roll/execute.go 79.41% (-0.12%) 170 (-1) 135 (-1) 35 👎
github.com/xataio/pgroll/pkg/roll/options.go 66.67% (-3.92%) 15 (-2) 10 (-2) 5 👎
github.com/xataio/pgroll/pkg/roll/roll.go 76.09% (ø) 46 35 11

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/xataio/pgroll/pkg/roll/execute_test.go

@andrew-farries andrew-farries marked this pull request as ready for review June 13, 2025 14:36
@andrew-farries andrew-farries requested a review from kvch June 13, 2025 14:37
@andrew-farries andrew-farries merged commit e7786f5 into main Jun 16, 2025
30 checks passed
@andrew-farries andrew-farries deleted the remove-no-version-schema-for-raw-sql-option branch June 16, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants