Use DropFunctionAction in remaning operations
#880
Conversation
pkg/migrations/trigger.go
Outdated
| @@ -41,6 +41,11 @@ type createTriggerAction struct { | |||
| cfg triggerConfig | |||
| } | |||
|
|
|||
| type dropTriggerAction struct { | |||
There was a problem hiding this comment.
Shouldn't this and the related code go with the other actions in dbactions.go?
There was a problem hiding this comment.
Also, this appears to duplicate the existing DropFunctionAction
pkg/migrations/trigger.go
Outdated
| } | ||
| } | ||
|
|
||
| func (a *dropTriggerAction) Execute(ctx context.Context) error { |
There was a problem hiding this comment.
The action is called dropTriggerAction but actually drops a function.
|
Ha, nice catch. I was looking for this action, but could not find it in |
kvch
force-pushed
the
refactoring-drop-trigger
branch
from
b9c3713 to
f871c45
Compare
kvch
changed the title
DBAction: DropFunctionActionDropFunctionAction in remaning operations
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Related #742