Add support for deparsing parenthesized sequence options list #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
force-pushed
the
feature-deparse-seq-op-list
branch
from
d0c521d to
01d3411
Compare
kvch
force-pushed
the
feature-deparse-seq-op-list
branch
from
01d3411 to
9fcf9cc
Compare
andrew-farries
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Have you tried using this in xataio/pgroll#605?
We may as well hold off merging this until we know it works there.
|
Yes, I tested it locally. That's why there is an extra branch in the repo: https://github.com/xataio/pg_query_go/tree/feature-deparse-seq-op-list |
kvch
added a commit
to xataio/pgroll
that referenced
this pull request
Jan 22, 2025
This PR adds support for generated columns in `create_table` and
`add_column` operations.
The column definition is extended with the setting named `generated`.
Define a stored column:
```json
...
"generated": {
"expression": "upper(name)"
}
```
Define a generated identity column:
```json
...
"generated": {
"identity": {
"user_specified_values": "ALWAYS",
"sequence_options": "start 5"
}
```
Identity columns are marked not null by default, so setting `nullable`
is unnecessary.
I changed the existing `fruits` table to use a generated identity column
as a primary key.
```json
{
"name": "08_create_fruits_table",
"operations": [
{
"create_table": {
"name": "fruits",
"columns": [
{
"name": "id",
"type": "bigint",
"pk": true,
"generated": {
"identity": {
"user_specified_values": "BY DEFAULT"
}
}
},
{
"name": "name",
"type": "varchar(255)",
"unique": true
},
{
"name": "price",
"type": "decimal(10,2)"
}
]
}
}
]
}
```
The PR also contains the transformation required by `sql2pgroll`
project.
Requires xataio/pg_query_go#7
---------
Co-authored-by: Andrew Farries <[email protected]>
andrew-farries
pushed a commit
that referenced
this pull request
Apr 25, 2025
Add support for deparsing parenthesized sequence options list
andrew-farries
pushed a commit
that referenced
this pull request
Apr 25, 2025
andrew-farries
pushed a commit
that referenced
this pull request
Apr 25, 2025
andrew-farries
pushed a commit
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the Go API with a new function:
This function is used to deparse sequence options. Example statement for generating identity columns and setting sequence options:
the
(START 5 INCREMENT 5)portion can be deparsed with this new function.Based on #6