Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Fix the wrong assignation of margins when the text is assigned #552

Merged

Conversation

Rabosa616
Copy link
Contributor

@Rabosa616 Rabosa616 commented Nov 13, 2020

Fix the wrong assignation of margins when the text is assigned.

Description of Change

There were no consistent margins between when the Badge was at the top positions or at the bottom as I showed in the first part of the issue #535.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@ghost
Copy link

ghost commented Nov 13, 2020

CLA assistant check
All CLA requirements met.

@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Rabosa616 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@Rabosa616 Rabosa616 marked this pull request as ready for review November 13, 2020 18:36
@Rabosa616 Rabosa616 marked this pull request as draft November 13, 2020 18:47
Remove margins when the badge is not shown
@Rabosa616 Rabosa616 force-pushed the BugFix/535_BadgeView_Margins branch from c0deb99 to 773fcc4 Compare November 13, 2020 18:55
@Rabosa616 Rabosa616 marked this pull request as ready for review November 14, 2020 17:09
@pictos
Copy link
Contributor

pictos commented Nov 14, 2020

@Rabosa616 can you verify your CLA status?

@Rabosa616
Copy link
Contributor Author

image
I don't know why the @dnfadmin says that CLA is not signed if I go to site I see that is signed

image

@pictos
Copy link
Contributor

pictos commented Nov 16, 2020

@jfversluis, do you have any idea about this issue?

@jfversluis jfversluis added a/BadgeView bug Something isn't working. Breaky break. labels Nov 16, 2020
@jfversluis
Copy link
Member

Hm it seems the GitHub checks thinks it's OK, so I guess all is in order. Maybe some kind of hiccup. Ignore it for now, we'll see what happens if you open a second PR :)

Copy link
Contributor

@AndreiMisiukevich AndreiMisiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreiMisiukevich AndreiMisiukevich merged commit d41a3b0 into xamarin:main Nov 17, 2020
@Rabosa616 Rabosa616 deleted the BugFix/535_BadgeView_Margins branch November 17, 2020 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/BadgeView bug Something isn't working. Breaky break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BadgeView Margins and Layout strange behaviour
6 participants