[Bug] Popup on UWP throws an exception when accessed from the nightly nuget

[bmacombe]

Description

Acts as if the UWP dll isn't being referenced or it's not package correctly. Works fine in the sample app at the develop branch head at time of report.

Android and iOS work as expected.

Steps to Reproduce

1. Run the sample app and click the button.

Expected Behavior

Popup opens

Actual Behavior

Not supported exception

Basic Information

• Version with issue: Nightly v.1.1.0-preview1010
• Last known good version:
• IDE: VS 19
• Platform Target Frameworks:
  • UWP: 1903
• Nuget Packages: Nightly v.1.1.0-preview1010
• Affected Devices:

Reproduction Link

https://github.com/bmacombe/XCT-Popup-Issue

[bmacombe]

@ahoefling @pictos FYI

[pictos]

I can confirm it, using the NuGet I can't open the popUp on UWP, but if I reference the XCT source code everything works fine.

[pictos]

@jfversluis any thought?

[jfversluis]

Well that's interesting. That looks like a rather custom message that is thrown in that exception, but I can't seem to find it.

Ooh hold on... Does this have anything to do with the multi-targeting? Maybe we got the naming wrong for the BasePopup and it's therefore not included in UWP and that's why it mentions UWP so specifically?

Naming and everything seem alright, hm this is an odd one :D

Do you have the stack trace or anything by any chance @bmacombe ?

[bmacombe]

Hey @jfversluis, sorry been a bit busy. But here is where the custom error comes from.

XamarinCommunityToolkit/src/CommunityToolkit/Xamarin.CommunityToolkit/Extensions/Navigation/NavigationExtensions.netstandard.macos.tvos.watchos.tizen.wpf.gtk.cs

Lines 1 to 16 in 3f7bc8c

	using System;
	using System.Threading.Tasks;
	using Xamarin.CommunityToolkit.UI.Views;
	using Xamarin.Forms;
	namespace Xamarin.CommunityToolkit.Extensions
	{
	public static partial class NavigationExtensions
	{
	static void PlatformShowPopup(BasePopup popup) =>
	throw new NotSupportedException($"The current platform '{Device.RuntimePlatform}' does not support Xamarin.CommunityToolkit.BasePopup");
	static Task<T> PlatformShowPopupAsync<T>(Popup<T> popup) =>
	throw new NotSupportedException($"The current platform '{Device.RuntimePlatform}' does not support Xamarin.CommunityToolkit.Popup.");
	}
	}

My un-educated guess is somehow that file is being built for UWP instead of the *.uwp.cs.

[SkyeHoefling]

As others posted, I am confirming this is happening with the sample project. I added the XCT as a submodule and the latest code in the develop branch appears to work.

My initial investigation points to a NuGet packaging issue. I copied the dll from my packages directory for uap10.0.19041 and then added it as a direct dll reference to the UWP app. When I ran the application the popup displayed without issue. I think the exception is being thrown because the .NET Standard dll is being used from the shared project and it is not swapping out the UWP dll in the project head.

[inforithmics]

I had the same problem. The reason was that it didnt work is that my UWP Project targeted 17763 / 1809
But Xamarin Toolkit was retargeted with the Popup Changes to 19031 / 2004
Which means when the MinVersion is not 19031 / 2004 it won't work. And it takes the .NET Standard 2.0 implementation which is not implemented.

I tried to do a pull request (but I made it of the wrong branch maybe i'll try again). My changes where the following.

changed following line in the Xamarin.CommunityToolkit.csproj

 <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);uap10.0.19041;netcoreapp3.1;net472;net471</TargetFrameworks>

to

 <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);uap10.0.17763;netcoreapp3.1;net472;net471</TargetFrameworks>
    <TargetPlatformVersion Condition="'$(TargetFramework)' == 'uap10.0.17763'">10.0.19041.0</TargetPlatformVersion>   

which means following

1. Min Version of UWP that it works is again 17763 / 1809
2. It Compiles it with the SDK Version of 19041 / 2004
   Which means all new Properties /Features are available.

I changed the Code in PopupRenderer.uwp.cs from

#if UWP_18362
       if (Element.Color == Color.Transparent)				{
	     flyoutStyle.Setters.Add(new Windows.UI.Xaml.Setter(FlyoutPresenter.IsDefaultShadowEnabledProperty, false));					
#endif

to

if (ApiInformation.IsPropertyPresent(typeof(FlyoutPresenter).FullName, nameof(FlyoutPresenter.IsDefaultShadowEnabledProperty)))
{
	if (Element.Color == Color.Transparent)
		flyoutStyle.Setters.Add(new Windows.UI.Xaml.Setter(FlyoutPresenter.IsDefaultShadowEnabledProperty, false));
}

it checks during the runtime if the isDefaultShadowEnabledProperty is available end only then it sets it. (Because in 17763 where it could run this Property is not available).