[Bug] Toucheffect raised when scrolling

[AlleSchonWeg]

Description

The touch effect is raised, when the user only want to scroll the control with the attached effect.
All infos about the issue are in the comments of the Pull Request. Starting at comment: #566 (comment)

Expected Behavior

Touch effect should only raised it not scrolling, like ListView or CollectionView items.

Actual Behavior

Touch effect is raised on scrolling

Basic Information

• Version with issue:
• Last known good version: 1.1.0
• IDE:
• Platform Target Frameworks:
  • iOS:
  • Android:
  • UWP:
• Android Support Library Version:
• Nuget Packages:
• Affected Devices:

Workaround

Reproduction imagery

Reproduction Link

[AndreiMisiukevich]

@AlleSchonWeg hi
Is it on Android, right?

[AlleSchonWeg]

Hi @AndreiMisiukevich ,

i have only a Simulator for iOS, but it looks like the same problem with scrolling.

And some other thing happens. The item stays in "touched" mode. I created a video. The labels are greyed out sometimes:

XCT.mp4

[IeuanWalker]

@AndreiMisiukevich Might want to take a look at the platform implementation of this - https://github.com/IeuanWalker/Xamarin.Forms.StateButton

I'm not sure how the effects are implemented, but with this control 'Pressed' and 'Released' events are always raised (even when scrolling), but 'Clicked' event is only raised when the user clicks, but doest get raised when scrolling a list.

[AndreiMisiukevich]

If you know how to fix that, then feel free to submit PR

[themronion]

Yeap, +1 here, also noticed this recently

[AlleSchonWeg]

Hi @AndreiMisiukevich,
on android i created a touch effect (ripple) which is only raised when the user selects an item. Not when scrolling. Perhaps you can use this and extend your touch effect:

         var label = new TextView(Context)
                    {
                        Text = $"Row ----- {i} in {noOfRows}",
                    };

                    label.Clickable = true;
                    label.Focusable = true;
                    int[] attrs = new int[] { Android.Resource.Attribute.SelectableItemBackground };
                    var typedArray = Context.ObtainStyledAttributes(attrs);
                    var drawableFromTheme = typedArray.GetDrawable(0);
                    typedArray.Recycle();
                    label.Foreground = drawableFromTheme;

In this example i used a label, which looks like this:

Android.Emulator.-.pixel_2_pie_9_0_-_api_28_5556.2021-05-26.21-22-54.mp4

[RenegadeVile]

This occurs with ScrollViews as well. Any View I add TouchEffect.NativeAnimation to will have that animation triggered when scrolling and I happen to start the scroll with a tap over said View.

[Seuleuzeuh]

Settings the xct:TouchEffect.DisallowTouchThreshold to 1 did the trick for me, using the NormalBackgroundColor and PressedBackgroundColor. And also with the LongPressCommand. All of that in elements of a CollectionView.