Fix: Prevent race condition in anonymous installer creation #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ForegroundInfoHandler and InstallerRepoImpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A persistent "Ready" notification would remain on screen throughout the installation process.
This was caused by a race condition in
InstallerRepoImpl.getOrCreate(null). Concurrent calls could each generate a separate installer instance with a new random ID before the other was properly cached. This resulted in an "orphan" instance whose initial notification was never updated or cancelled, while a second "live" instance proceeded with the installation.The
getOrCreatelogic is now hardened to be fully thread-safe for anonymous (null-ID) requests. It now tracks the active anonymous instance ID to enforce a true singleton pattern for these initializations, ensuring any subsequent concurrent calls correctly return the one existing instance. This guarantees a singleInstallerRepoandNotification IDper active installation, resolving the orphaned notification bug.