-
Notifications
You must be signed in to change notification settings - Fork 168
Provide API support for selective role sharing with application sharing #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- mark Deprecated APIs - Fix formatting - Use constants - Fix response params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enables selective and bulk application sharing APIs with pagination and sharing initiation metadata.
- Adds new POST, PATCH, and pagination-enabled GET endpoints for application sharing and unsharing.
- Enhances
/shareGET to returnsharingInitiationModeand cursor‐based before/after pagination. - Implements core service methods for selective, all, and incremental sharing operations.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| applications.yaml | Defines new share/unshare endpoints, parameters, and response schemas with pagination and initiation mode |
| ApplicationsApiServiceImpl.java | Exposes new delegate methods for share-with-all, share-selected, unshare, and patch sharing |
| ServerApplicationSharingService.java | Implements business logic for selective and bulk share/unshare operations, builds paginated responses |
| ApplicationManagementEndpointConstants.java | Introduces constants for query params, link rels, and async status |
| BasicOrganizationResponse.java | Extends response model with parentId, hasChildren, depthFromRoot, sharingInitiationMode, and roles |
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Show resolved
Hide resolved
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Outdated
Show resolved
Hide resolved
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Outdated
Show resolved
Hide resolved
… add review suggestions
...rbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java
Show resolved
Hide resolved
…agement/org.wso2.carbon.identity.api.server.application.management.v1/src/main/java/org/wso2/carbon/identity/api/server/application/management/v1/core/ServerApplicationSharingService.java Co-authored-by: Sahan Dilshan <[email protected]>
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/16444342014
Purpose
Issue: wso2/product-is#21100
Ported the implementation from: #906
Additional changes introduced:
Related PR(s)
[Merge after] wso2-extensions/identity-organization-management#525