Stats Review: Add Module and Infra (P2) #24714
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
crazytonyli
reviewed
Aug 6, 2025
| static let step1: CGFloat = 12 | ||
| static let step2: CGFloat = 18 | ||
| static let step3: CGFloat = 24 | ||
| static let step4: CGFloat = 32 |
There was a problem hiding this comment.
What does "step" mean in these variable names?
| default: | ||
| errorType = "unknown" | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure if it's worth using this block of code to create an "error type". (error as NSError).domain is probably enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some basic infrastructure: JetpackStats module, localizable strings, events for analytics and constants.