chore: remove redundant auto-imported type imports by RedStar071 · Pull Request #213 · wolfstar-project/wolfstar.rocks

RedStar071 · 2026-05-27T12:09:57Z

🔗 Linked issue

N/A

🧭 Context

Nuxt auto-imports types declared in #shared/types, #auth-utils, and #shared/types/discord. Explicit import type statements for these symbols are redundant and create unnecessary coupling to the import path.

📚 Description

Remove explicit import type statements that are already satisfied by Nuxt's auto-import layer:

app/components/guild/settings/DisabledCommands.vue — removed FlattenedCommand from #shared/types (kept DisableCommands imported to satisfy knip/CI unused-export checks)
app/composables/useUser.ts — removed User from #auth-utils
test/mocks/discord.ts — removed User, FlattenedEmoji, FlattenedGuildChannel, FlattenedRole, OauthFlattenedGuild
test/nuxt/components/BuildEnvironment.spec.ts — removed BuildInfo from #shared/types
test/nuxt/components/guild/settings/DisabledCommands.spec.ts — removed FlattenedCommand from #shared/types

No runtime behaviour changes. Type checking and tests continue to pass.

Copilot

Copilot wasn't able to review any files in this pull request.

coderabbitai · 2026-05-27T12:10:49Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ba4b6a8f-d95e-4b9f-9220-ed58d213b45a

📥 Commits

Reviewing files that changed from the base of the PR and between 9d67884 and c6892cc.

📒 Files selected for processing (1)

app/components/guild/settings/DisabledCommands.vue

📝 Walkthrough

Summary by CodeRabbit

Release Notes

Chores
- Codebase housekeeping: removed unused type-only imports to simplify internal typings with no behaviour changes.
Tests
- Updated test files and mocks to reflect the typing cleanup; test logic and app behaviour remain unchanged.

Walkthrough

Type-only imports were removed across five files. DisabledCommands.vue narrowed its #shared/types import to remove FlattenedCommand (the component still references that type in annotations); tests and utility files had unused type imports removed.

Changes

Type import cleanup

Layer / File(s)	Summary
DisabledCommands component and test type imports `app/components/guild/settings/DisabledCommands.vue`, `test/nuxt/components/guild/settings/DisabledCommands.spec.ts`	`DisabledCommands.vue` narrows the `#shared/types` import to remove `FlattenedCommand` while the file still uses that type in props/signatures; the spec file removes the now-unused `FlattenedCommand` import.
Utility and test helper type import cleanup `app/composables/useUser.ts`, `test/mocks/discord.ts`, `test/nuxt/components/BuildEnvironment.spec.ts`	Removed unused type-only imports: `User` from `useUser.ts`, Discord flattened types from `test/mocks/discord.ts`, and `BuildInfo` from `BuildEnvironment.spec.ts`.

Suggested reviewers

lorypelli

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing redundant auto-imported type imports across the codebase.
Description check	✅ Passed	The description clearly explains the context, rationale, and all files affected by the removal of redundant type imports.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/remove-auto-imported-imports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sentry · 2026-05-27T12:14:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.52%. Comparing base (b8f2720) to head (c6892cc).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files         103      103           
  Lines        2306     2306           
  Branches      472      472           
=======================================
  Hits         1534     1534           
  Misses        412      412           
  Partials      360      360

Flag	Coverage Δ
component	`57.04% <ø> (ø)`
unit	`67.56% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/components/guild/settings/DisabledCommands.vue	`56.57% <ø> (ø)`
app/composables/useUser.ts	`50.00% <ø> (ø)`
test/mocks/discord.ts	`100.00% <ø> (ø)`

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codspeed-hq · 2026-05-27T12:15:06Z

Merging this PR will not alter performance

✅ 44 untouched benchmarks

_{Comparing chore/remove-auto-imported-imports (c6892cc) with main (b8f2720)}

RedStar071 · 2026-05-27T15:13:49Z

@copilot fix falied workflow

Copilot · 2026-05-27T15:20:45Z

@copilot fix falied workflow

Fixed in c6892cc. I investigated the failed ci run and patched the root cause by restoring DisableCommands type import in app/components/guild/settings/DisabledCommands.vue, which resolves the knip unused-export failure.

lorypelli

LGTM!

This PR will deploy the following changes to production (`wolfstar.rocks`). **Next version: `v0.7.0`** (current: `v0.6.3`) ### Features - feat(tests): auto-generate ephemeral secrets for CI builds (`fd3a0255`) - feat(semantic-pr): update scopes for PR validation (`2fb7ab56`) - feat(test-secrets): add module for auto-generating CI secrets (`3baf470c`) ### Fixes - fix(auth): refresh Discord OAuth tokens before API calls (#218) (`4dd1e5cf`) - fix(ui): serve Geist and GeistMono from local provider (#214) (`b8f27202`) - fix: improve release workflow and fix release-notes output (#211) (`f7ae44fb`) - fix(package): update node engine requirement to >=24 (`b66e0040`) - fix(ci): resolve failing workflow checks (`face5c43`) ### Other Changes - chore: resolve release PR #217 merge conflicts (#219) (`af83b2af`) - chore: migrate design reference from .atlas to .claude (#216) (`cadf476e`) - chore: remove redundant auto-imported type imports (#213) (`be362fbc`) - chore(deps): upgrade knip to v6 and enable treatConfigHintsAsErrors (#212) (`1ba87ecb`) - chore(deps): update test packages (#206) (`1187f76e`) - chore(ci): pin playwright container image to sha256 digest (#202) (`4eef7689`) - chore: replace create-pr-commit skill with full create-pull-request skill (#201) (`6874c781`) - ci: improve release workflows and permissions (`9839e301`) - ci: enable reuse of existing server in CI environment (`ffa2b640`) - ci: fix browser container digest, version comment, and restore NODE_OPTIONS/secrets (`8fae2422`) - ci: remove NODE_OPTIONS from component and build tests (`728c7951`) - chore: rename codecov file to use correct version (`fba616b7`) - ci: update scopes in semantic PR workflow (`2e2fd6fe`) - ci: remove hardcoded secrets from browser tests (`a7ddfdb0`) - chore: rename `continuous-integration` to `ci` workflow (`0ee01169`) - ci: simplify permissions in release PR workflow (`80c69cad`) - ci: fix all zizmor security analysis findings (`5ebc15ee`) - ci: update reporter configuration for CI environments (`2a6166c6`) - ci: harden GitHub Actions workflows (`2d4600ea`) - chore(pnpm): add minimumReleaseAge and clean up config comments (`729fadb3`) - chore: set package version to 0.0.0 (`afd42056`) ### Uncategorized - revert "fix(ci): resolve failing workflow checks" (`a684d62e`) --- > Merging this PR will: > - Deploy to `wolfstar.rocks` via Netlify > - Create a `v0.7.0` tag and GitHub Release

chore: remove redundant auto-imported type imports

e8f6f6e

Copilot AI review requested due to automatic review settings May 27, 2026 12:09

Copilot AI reviewed May 27, 2026

View reviewed changes

Merge branch 'main' into chore/remove-auto-imported-imports

cdf55a5

Merge branch 'main' into chore/remove-auto-imported-imports

9d67884

Copilot started work on behalf of RedStar071 May 27, 2026 15:14 View session

fix(types): restore DisableCommands type import for knip

c6892cc

Copilot finished work on behalf of RedStar071 May 27, 2026 15:22

RedStar071 requested a review from lorypelli May 27, 2026 15:52

lorypelli approved these changes May 27, 2026

View reviewed changes

kodiakhq Bot merged commit be362fb into main May 27, 2026
18 of 19 checks passed

kodiakhq Bot deleted the chore/remove-auto-imported-imports branch May 27, 2026 15:53

This was referenced May 27, 2026

chore: release v0.7.0 #210

Closed

chore: release v0.7.0 #217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove redundant auto-imported type imports#213

chore: remove redundant auto-imported type imports#213
kodiakhq[bot] merged 4 commits into
mainfrom
chore/remove-auto-imported-imports

RedStar071 commented May 27, 2026 •

edited by Copilot AI

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot commented May 27, 2026 •

edited

Loading

Summary by CodeRabbit

Release Notes

Walkthrough

Changes

Suggested reviewers

Uh oh!

sentry Bot commented May 27, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented May 27, 2026 •

edited

Loading

Uh oh!

RedStar071 commented May 27, 2026

Uh oh!

Copilot AI commented May 27, 2026

Uh oh!

lorypelli left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

RedStar071 commented May 27, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Walkthrough

Changes

Suggested reviewers

Uh oh!

sentry Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

RedStar071 commented May 27, 2026

Uh oh!

Copilot AI commented May 27, 2026

Uh oh!

lorypelli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RedStar071 commented May 27, 2026 •

edited by Copilot AI

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading

sentry Bot commented May 27, 2026 •

edited

Loading

codspeed-hq Bot commented May 27, 2026 •

edited

Loading